Skip to content

Commit

Permalink
doc: do not advise to cancel full CI on onboarding
Browse files Browse the repository at this point in the history
Refs: #21938 (comment)
and discussion below the comment.

PR-URL: #21977
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
  • Loading branch information
vsemozhetbyt committed Jul 26, 2018
1 parent 36a15a1 commit a9f32a3
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions doc/onboarding.md
Original file line number Diff line number Diff line change
Expand Up @@ -213,9 +213,7 @@ needs to be pointed out separately during the onboarding.
* Optionally, include your personal pronouns.
* Label your pull request with the `doc` and `notable-change` labels.
* Run CI on the PR. Because the PR does not affect any code, use the
`node-test-pull-request-lite-pipeline` CI task. Alternatively, use the usual
`node-test-pull-request` CI task and cancel it after the linter and one other
subtask have passed.
`node-test-pull-request-lite-pipeline` CI task.
* After one or two approvals, land the PR (PRs of this type do not need to wait
for 48/72 hours to land).
* Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:`
Expand Down

0 comments on commit a9f32a3

Please sign in to comment.