http2: return this for Http2ServerRequest#setTimeout

Fixes: #33993 PR-URL: #33994 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
nodejs · Jun 25, 2020 · ac80fed · ac80fed
1 parent 3646872
commit ac80fed
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/internal/http2/compat.js b/lib/internal/http2/compat.js
@@ -411,9 +411,9 @@ class Http2ServerRequest extends Readable {
   }
 
   setTimeout(msecs, callback) {
-    if (this[kState].closed)
-      return;
-    this[kStream].setTimeout(msecs, callback);
+    if (!this[kState].closed)
+      this[kStream].setTimeout(msecs, callback);
+    return this;
   }
 }
 

diff --git a/test/parallel/test-http2-compat-serverrequest-settimeout.js b/test/parallel/test-http2-compat-serverrequest-settimeout.js
@@ -3,15 +3,17 @@
 const common = require('../common');
 if (!common.hasCrypto)
   common.skip('missing crypto');
+const assert = require('assert');
 const http2 = require('http2');
 
 const msecs = common.platformTimeout(1);
 const server = http2.createServer();
 
 server.on('request', (req, res) => {
-  req.setTimeout(msecs, common.mustCall(() => {
+  const request = req.setTimeout(msecs, common.mustCall(() => {
     res.end();
   }));
+  assert.strictEqual(request, req);
   req.on('timeout', common.mustCall());
   res.on('finish', common.mustCall(() => {
     req.setTimeout(msecs, common.mustNotCall());