Skip to content

Commit

Permalink
test: clarify role of domains in test
Browse files Browse the repository at this point in the history
Add a comment to clarify how the tests work and their purpose.

Also removes unnecessary assignment of domain module to a variable.

PR-URL: #4474
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
  • Loading branch information
Trott committed Jan 2, 2016
1 parent 1170b26 commit b16a50d
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 3 deletions.
8 changes: 7 additions & 1 deletion test/parallel/test-microtask-queue-integration-domain.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
'use strict';
require('../common');
var assert = require('assert');
var domain = require('domain');

// Requiring the domain module here changes the function that is used by node to
// call process.nextTick's callbacks to a variant that specifically handles
// domains. We want to test this specific variant in this test, and so even if
// the domain module is not used, this require call is needed and must not be
// removed.
require('domain');

var implementations = [
function(fn) {
Expand Down
8 changes: 7 additions & 1 deletion test/parallel/test-microtask-queue-run-domain.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
'use strict';
require('../common');
var assert = require('assert');
var domain = require('domain');

// Requiring the domain module here changes the function that is used by node to
// call process.nextTick's callbacks to a variant that specifically handles
// domains. We want to test this specific variant in this test, and so even if
// the domain module is not used, this require call is needed and must not be
// removed.
require('domain');

function enqueueMicrotask(fn) {
Promise.resolve().then(fn);
Expand Down
8 changes: 7 additions & 1 deletion test/parallel/test-microtask-queue-run-immediate-domain.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
'use strict';
require('../common');
var assert = require('assert');
var domain = require('domain');

// Requiring the domain module here changes the function that is used by node to
// call process.nextTick's callbacks to a variant that specifically handles
// domains. We want to test this specific variant in this test, and so even if
// the domain module is not used, this require call is needed and must not be
// removed.
require('domain');

function enqueueMicrotask(fn) {
Promise.resolve().then(fn);
Expand Down

0 comments on commit b16a50d

Please sign in to comment.