quic: remove unused callback function

PR-URL: #34137 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>
nodejs · Jul 1, 2020 · b1fab88 · b1fab88
1 parent 3bae2d5
commit b1fab88
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 11 deletions.
diff --git a/lib/internal/quic/core.js b/lib/internal/quic/core.js
@@ -474,14 +474,6 @@ function onSessionQlog(str) {
  }
 }
 
-// Called when an error occurs in a QuicSession. When this happens,
-// the only remedy is to destroy the session.
-function onSessionError(error) {
- if (this[owner_symbol]) {
- this[owner_symbol].destroy(error);
- }
-}
-
 // Called by the C++ internals when a client QuicSession receives
 // a version negotiation response from the server.
 function onSessionVersionNegotiation(
@@ -570,7 +562,6 @@ setCallbacks({
  onSessionClientHello,
  onSessionClose,
  onSessionDestroyed,
- onSessionError,
  onSessionHandshake,
  onSessionKeylog,
  onSessionQlog,

diff --git a/src/env.h b/src/env.h
@@ -455,7 +455,6 @@ constexpr size_t kFsStatsBufferLength =
  V(quic_on_session_client_hello_function, v8::Function) \
  V(quic_on_session_close_function, v8::Function) \
  V(quic_on_session_destroyed_function, v8::Function) \
- V(quic_on_session_error_function, v8::Function) \
  V(quic_on_session_handshake_function, v8::Function) \
  V(quic_on_session_keylog_function, v8::Function) \
  V(quic_on_session_path_validation_function, v8::Function) \

diff --git a/src/quic/node_quic.cc b/src/quic/node_quic.cc
@@ -60,7 +60,6 @@ void QuicSetCallbacks(const FunctionCallbackInfo<Value>& args) {
  SETFUNCTION("onSessionClientHello", session_client_hello);
  SETFUNCTION("onSessionClose", session_close);
  SETFUNCTION("onSessionDestroyed", session_destroyed);
- SETFUNCTION("onSessionError", session_error);
  SETFUNCTION("onSessionHandshake", session_handshake);
  SETFUNCTION("onSessionKeylog", session_keylog);
  SETFUNCTION("onSessionUsePreferredAddress", session_use_preferred_address);