-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: add tests for clearBuffer state machine
This checks to see that clearBuffer appropriately decrements the correct values in _writableState when clearBuffer is invoked in end. Fixes: #8687 PR-URL: #9922 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
- Loading branch information
1 parent
11635e2
commit b3b7686
Showing
1 changed file
with
57 additions
and
0 deletions.
There are no files selected for viewing
57 changes: 57 additions & 0 deletions
57
test/parallel/test-stream-writableState-uncorked-bufferedRequestCount.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const stream = require('stream'); | ||
|
||
const writable = new stream.Writable(); | ||
|
||
writable._writev = common.mustCall((chunks, cb) => { | ||
assert.equal(chunks.length, 2, 'two chunks to write'); | ||
cb(); | ||
}, 1); | ||
|
||
writable._write = common.mustCall((chunk, encoding, cb) => { | ||
cb(); | ||
}, 1); | ||
|
||
// first cork | ||
writable.cork(); | ||
assert.strictEqual(writable._writableState.corked, 1); | ||
assert.strictEqual(writable._writableState.bufferedRequestCount, 0); | ||
|
||
// cork again | ||
writable.cork(); | ||
assert.strictEqual(writable._writableState.corked, 2); | ||
|
||
// the first chunk is buffered | ||
writable.write('first chunk'); | ||
assert.strictEqual(writable._writableState.bufferedRequestCount, 1); | ||
|
||
// first uncork does nothing | ||
writable.uncork(); | ||
assert.strictEqual(writable._writableState.corked, 1); | ||
assert.strictEqual(writable._writableState.bufferedRequestCount, 1); | ||
|
||
process.nextTick(uncork); | ||
|
||
// the second chunk is buffered, because we uncork at the end of tick | ||
writable.write('second chunk'); | ||
assert.strictEqual(writable._writableState.corked, 1); | ||
assert.strictEqual(writable._writableState.bufferedRequestCount, 2); | ||
|
||
function uncork() { | ||
// second uncork flushes the buffer | ||
writable.uncork(); | ||
assert.strictEqual(writable._writableState.corked, 0); | ||
assert.strictEqual(writable._writableState.bufferedRequestCount, 0); | ||
|
||
// verify that end() uncorks correctly | ||
writable.cork(); | ||
writable.write('third chunk'); | ||
writable.end(); | ||
|
||
// end causes an uncork() as well | ||
assert.strictEqual(writable._writableState.corked, 0); | ||
assert.strictEqual(writable._writableState.bufferedRequestCount, 0); | ||
} |