stream: always delay construct callback by a nextTick

Signed-off-by: Matteo Collina <hello@matteocollina.com> Fixes: #46765 PR-URL: #46818 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
nodejs · Mar 13, 2023 · b7bb4e3 · b7bb4e3
1 parent 5921af7
commit b7bb4e3
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/lib/internal/streams/destroy.js b/lib/internal/streams/destroy.js
@@ -272,9 +272,11 @@ function constructNT(stream) {
   }
 
   try {
-    stream._construct(onConstruct);
+    stream._construct((err) => {
+      process.nextTick(onConstruct, err);
+    });
   } catch (err) {
-    onConstruct(err);
+    process.nextTick(onConstruct, err);
   }
 }
 

diff --git a/test/parallel/test-stream2-transform.js b/test/parallel/test-stream2-transform.js
@@ -468,3 +468,27 @@ const { PassThrough, Transform } = require('stream');
     assert.strictEqual(ended, true);
   }));
 }
+
+{
+  const s = new Transform({
+    objectMode: true,
+    construct(callback) {
+      this.push('header from constructor');
+      callback();
+    },
+    transform: (row, encoding, callback) => {
+      callback(null, row);
+    },
+  });
+
+  const expected = [
+    'header from constructor',
+    'firstLine',
+    'secondLine',
+  ];
+  s.on('data', common.mustCall((data) => {
+    assert.strictEqual(data.toString(), expected.shift());
+  }, 3));
+  s.write('firstLine');
+  process.nextTick(() => s.write('secondLine'));
+}