Skip to content

Commit

Permalink
build: fix --enable-d8 builds
Browse files Browse the repository at this point in the history
Add `v8_abseil` as a dependency for `d8` and use scraping to pick up
the list of source files (including the previously missing
`src/d8/d8-test.cc`).

PR-URL: #53106
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
  • Loading branch information
richardlau authored and targos committed Jun 1, 2024
1 parent a371dea commit b7d7e9a
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions tools/v8_gypfiles/d8.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
'v8.gyp:v8_libbase',
'v8.gyp:v8_libplatform',
'v8.gyp:generate_bytecode_builtins_list',
'v8.gyp:v8_abseil',
],
# Generated source files need this explicitly:
'include_dirs+': [
Expand All @@ -28,15 +29,7 @@
'<(SHARED_INTERMEDIATE_DIR)',
],
'sources': [
'<(V8_ROOT)/src/d8/async-hooks-wrapper.cc',
'<(V8_ROOT)/src/d8/async-hooks-wrapper.h',
'<(V8_ROOT)/src/d8/d8-console.cc',
'<(V8_ROOT)/src/d8/d8-console.h',
'<(V8_ROOT)/src/d8/d8-js.cc',
'<(V8_ROOT)/src/d8/d8-platforms.cc',
'<(V8_ROOT)/src/d8/d8-platforms.h',
'<(V8_ROOT)/src/d8/d8.cc',
'<(V8_ROOT)/src/d8/d8.h',
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "v8_executable.\\"d8\\".*?sources = ")',
],
'conditions': [
[ 'want_separate_host_toolset==1', {
Expand Down

0 comments on commit b7d7e9a

Please sign in to comment.