url: error when domainTo*() is called w/o argument

PR-URL: #12507 Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · May 1, 2017 · b9b93f2 · b9b93f2
1 parent 1adb08e
commit b9b93f2
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -1308,11 +1308,17 @@ function originFor(url, base) {
 }
 
 function domainToASCII(domain) {
+  if (arguments.length < 1)
+    throw new TypeError('"domain" argument must be specified');
+
   // toUSVString is not needed.
   return binding.domainToASCII(`${domain}`);
 }
 
 function domainToUnicode(domain) {
+  if (arguments.length < 1)
+    throw new TypeError('"domain" argument must be specified');
+
   // toUSVString is not needed.
   return binding.domainToUnicode(`${domain}`);
 }

diff --git a/test/parallel/test-whatwg-url-domainto.js b/test/parallel/test-whatwg-url-domainto.js
@@ -12,6 +12,15 @@ const { domainToASCII, domainToUnicode } = require('url');
 // Tests below are not from WPT.
 const tests = require('../fixtures/url-idna.js');
 
+{
+  assert.throws(() => domainToASCII(),
+                /^TypeError: "domain" argument must be specified$/);
+  assert.throws(() => domainToUnicode(),
+                /^TypeError: "domain" argument must be specified$/);
+  assert.strictEqual(domainToASCII(undefined), 'undefined');
+  assert.strictEqual(domainToUnicode(undefined), 'undefined');
+}
+
 {
   for (const [i, { ascii, unicode }] of tests.valid.entries()) {
     assert.strictEqual(ascii, domainToASCII(unicode),