esm: refactor test-esm-named-exports

nodejs · Sep 4, 2023 · b9f29d0 · b9f29d0
1 parent 47c5152
commit b9f29d0
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 4 deletions.
diff --git a/test/es-module/test-esm-named-exports.js b/test/es-module/test-esm-named-exports.js
@@ -1,4 +1,4 @@
-// Flags: --experimental-loader ./test/fixtures/es-module-loaders/builtin-named-exports-loader.mjs
+// Flags: --import ./test/fixtures/es-module-loaders/builtin-named-exports.mjs
 'use strict';
 
 require('../common');

diff --git a/test/es-module/test-esm-named-exports.mjs b/test/es-module/test-esm-named-exports.mjs
@@ -1,4 +1,4 @@
-// Flags: --experimental-loader ./test/fixtures/es-module-loaders/builtin-named-exports-loader.mjs
+// Flags: --import ./test/fixtures/es-module-loaders/builtin-named-exports.mjs
 import '../common/index.mjs';
 import { readFile, __fromLoader } from 'fs';
 import assert from 'assert';

diff --git a/test/fixtures/es-module-loaders/builtin-named-exports-loader.mjs b/test/fixtures/es-module-loaders/builtin-named-exports-loader.mjs
@@ -1,7 +1,11 @@
-import module from 'module';
+import module from 'node:module';
 import { readFileSync } from 'node:fs';
 
-const GET_BUILTIN = `$__get_builtin_hole_${Date.now()}`;
+/** @type {string} */
+let GET_BUILTIN;
+export function initialize(data) {
+  GET_BUILTIN = data.GET_BUILTIN;
+}
 
 export function globalPreload() {
   return `Object.defineProperty(globalThis, ${JSON.stringify(GET_BUILTIN)}, {

diff --git a/test/fixtures/es-module-loaders/builtin-named-exports.mjs b/test/fixtures/es-module-loaders/builtin-named-exports.mjs
@@ -0,0 +1,19 @@
+import * as fixtures from '../../common/fixtures.mjs';
+import { createRequire, register } from 'node:module';
+
+const require = createRequire(import.meta.url);
+
+const GET_BUILTIN = `$__get_builtin_hole_${Date.now()}`;
+Object.defineProperty(globalThis, GET_BUILTIN, {
+  value: (builtinName) => {
+    return require(builtinName);
+  },
+  enumerable: false,
+  configurable: false,
+});
+
+register(fixtures.fileURL('es-module-loaders/builtin-named-exports-loader.mjs'), {
+  data: {
+    GET_BUILTIN,
+  },
+});