Skip to content

Commit

Permalink
inspector: add missing virtual destructor
Browse files Browse the repository at this point in the history
This fixes a resource leak detected by a Coverity scan.

PR-URL: #13198
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
  • Loading branch information
Eugene Ostroukhov authored and jasnell committed May 28, 2017
1 parent 145ab05 commit bb77cce
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/inspector_agent.cc
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ class JsBindingsSessionDelegate : public InspectorSessionDelegate {
v8::WeakCallbackType::kParameter);
}

virtual ~JsBindingsSessionDelegate() {
~JsBindingsSessionDelegate() override {
session_.Reset();
receiver_.Reset();
callback_.Reset();
Expand Down
1 change: 1 addition & 0 deletions src/inspector_agent.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ namespace inspector {

class InspectorSessionDelegate {
public:
virtual ~InspectorSessionDelegate() = default;
virtual bool WaitForFrontendMessage() = 0;
virtual void OnMessage(const v8_inspector::StringView& message) = 0;
};
Expand Down

0 comments on commit bb77cce

Please sign in to comment.