Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector: add missing virtual destructor #13198

Closed
wants to merge 1 commit into from
Closed

inspector: add missing virtual destructor #13198

wants to merge 1 commit into from

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented May 24, 2017

This fixes a resource leak detected by a Coverity scan.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

inspector

inspector: add missing virtual destructor
624ce28 
This fixes a resource leak detected by a Coverity scan.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x inspector Issues and PRs related to the V8 inspector protocol labels May 24, 2017
@eugeneo
Copy link
Contributor Author

eugeneo commented May 24, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8287/

@addaleax
Copy link
Member

Landed in 21c0c02

@addaleax addaleax closed this May 26, 2017
addaleax pushed a commit that referenced this pull request May 26, 2017
@addaleax
inspector: add missing virtual destructor
21c0c02 
This fixes a resource leak detected by a Coverity scan.

PR-URL: #13198
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
jasnell pushed a commit that referenced this pull request May 28, 2017
@jasnell
inspector: add missing virtual destructor
bb77cce 
This fixes a resource leak detected by a Coverity scan.

PR-URL: #13198
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@aliscco aliscco mentioned this pull request Apr 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@alexkozy alexkozy alexkozy approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eugeneo @addaleax @alexkozy @jasnell @MylesBorins @nodejs-github-bot