benchmark: fix race condition on fs benchs

nodejs · Oct 4, 2023 · bc9e25f · bc9e25f
1 parent 95b8f5d
commit bc9e25f
Show file tree

Hide file tree

Showing 5 changed files with 60 additions and 30 deletions.
diff --git a/benchmark/fs/readfile-partitioned.js b/benchmark/fs/readfile-partitioned.js
@@ -43,11 +43,17 @@ function main({ len, duration, concurrent, encoding }) {
     const totalOps = reads + zips;
     benchEnded = true;
     bench.end(totalOps);
-    try {
-      fs.unlinkSync(filename);
-    } catch {
-      // Continue regardless of error.
-    }
+
+    // This delay is needed because on windows this can cause
+    // race condition with afterRead, which makes this benchmark
+    // fails to delete the temp file
+    setTimeout(() => {
+      try {
+        fs.unlinkSync(filename);
+      } catch {
+        // Continue regardless of error.
+      }
+    }, 10);
   }, duration * 1000);
 
   function read() {

diff --git a/benchmark/fs/readfile-permission-enabled.js b/benchmark/fs/readfile-permission-enabled.js
@@ -41,12 +41,18 @@ function main({ len, duration, concurrent, encoding }) {
   setTimeout(() => {
     benchEnded = true;
     bench.end(reads);
-    try {
-      fs.unlinkSync(filename);
-    } catch {
-      // Continue regardless of error.
-    }
-    process.exit(0);
+
+    // This delay is needed because on windows this can cause
+    // race condition with afterRead, which makes this benchmark
+    // fails to delete the temp file
+    setTimeout(() => {
+      try {
+        fs.unlinkSync(filename);
+      } catch {
+        // Continue regardless of error.
+      }
+      process.exit(0);
+    }, 10);
   }, duration * 1000);
 
   function read() {

diff --git a/benchmark/fs/readfile-promises.js b/benchmark/fs/readfile-promises.js
@@ -41,12 +41,18 @@ function main({ len, duration, concurrent, encoding }) {
   setTimeout(() => {
     benchEnded = true;
     bench.end(writes);
-    try {
-      fs.unlinkSync(filename);
-    } catch {
-      // Continue regardless of error.
-    }
-    process.exit(0);
+
+    // This delay is needed because on windows this can cause
+    // race condition with afterRead, which makes this benchmark
+    // fails to delete the temp file
+    setTimeout(() => {
+      try {
+        fs.unlinkSync(filename);
+      } catch {
+        // Continue regardless of error.
+      }
+      process.exit(0);
+    }, 10);
   }, duration * 1000);
 
   function read() {

diff --git a/benchmark/fs/readfile.js b/benchmark/fs/readfile.js
@@ -34,12 +34,18 @@ function main({ len, duration, concurrent, encoding }) {
   setTimeout(() => {
     benchEnded = true;
     bench.end(reads);
-    try {
-      fs.unlinkSync(filename);
-    } catch {
-      // Continue regardless of error.
-    }
-    process.exit(0);
+
+    // This delay is needed because on windows this can cause
+    // race condition with afterRead, which makes this benchmark
+    // fails to delete the temp file
+    setTimeout(() => {
+      try {
+        fs.unlinkSync(filename);
+      } catch {
+        // Continue regardless of error.
+      }
+      process.exit(0);
+    }, 10);
   }, duration * 1000);
 
   function read() {

diff --git a/benchmark/fs/writefile-promises.js b/benchmark/fs/writefile-promises.js
@@ -43,14 +43,20 @@ function main({ encodingType, duration, concurrent, size }) {
   setTimeout(() => {
     benchEnded = true;
     bench.end(writes);
-    for (let i = 0; i < filesWritten; i++) {
-      try {
-        fs.unlinkSync(`${filename}-${i}`);
-      } catch {
-        // Continue regardless of error.
+
+    // This delay is needed because on windows this can cause
+    // race condition with afterRead, which makes this benchmark
+    // fails to delete the temp file
+    setTimeout(() => {
+      for (let i = 0; i < filesWritten; i++) {
+        try {
+          fs.unlinkSync(`${filename}-${i}`);
+        } catch {
+          // Continue regardless of error.
+        }
       }
-    }
-    process.exit(0);
+      process.exit(0);
+    }, 10);
   }, duration * 1000);
 
   function write() {