http: don't emit 'data' after 'error'

nodejs · Aug 18, 2019 · be5940b · be5940b
1 parent 5dee17b
commit be5940b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/lib/_http_client.js b/lib/_http_client.js
@@ -399,9 +399,6 @@ function socketErrorListener(err) {
  req.emit('error', err);
  }
 
- // Handle any pending data
- socket.read();
-
  const parser = socket.parser;
  if (parser) {
  parser.finish();

diff --git a/test/parallel/test-http-client-read-in-error.js b/test/parallel/test-http-client-read-in-error.js
@@ -1,5 +1,5 @@
 'use strict';
-require('../common');
+const common = require('../common');
 const net = require('net');
 const http = require('http');
 
@@ -37,4 +37,5 @@ http.request({
  agent
 }).once('error', function() {
  console.log('ignore');
+ this.on('data', common.mustNotCall());
 });