Skip to content

Commit

Permalink
squash: add note to onboarding doc
Browse files Browse the repository at this point in the history
  • Loading branch information
Trott committed Dec 30, 2017
1 parent 295ae9b commit beaafb3
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions doc/onboarding.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,9 @@ onboarding session.
avoid stalling the pull request.
* Note that they are nits when you comment: `Nit: change foo() to bar().`
* If they are stalling the pull request, fix them yourself on merge.
* Insofar as possible, issues should be identified by tools rather than human
reviewers. If you are leaving comments that could be identified by tools but
are not, consider implementing the necessary tooling.
* Minimum wait for comments time
* There is a minimum waiting time which we try to respect for non-trivial
changes, so that people who may have important input in such a distributed
Expand Down

0 comments on commit beaafb3

Please sign in to comment.