Skip to content

Commit

Permalink
fs: use default w flag for writeFileSync with utf8 encoding
Browse files Browse the repository at this point in the history
  • Loading branch information
MuriloKakazu committed Dec 1, 2023
1 parent 2f40652 commit c323642
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions lib/fs.js
Original file line number Diff line number Diff line change
Expand Up @@ -2343,6 +2343,8 @@ function writeFileSync(path, data, options) {

validateBoolean(flush, 'options.flush');

const flag = options.flag || 'w';

// C++ fast path for string data and UTF8 encoding
if (typeof data === 'string' && (options.encoding === 'utf8' || options.encoding === 'utf-8')) {
if (!isInt32(path)) {
Expand All @@ -2351,7 +2353,7 @@ function writeFileSync(path, data, options) {

return binding.writeFileUtf8(
path, data,
stringToFlags(options.flag),
stringToFlags(flag),
parseFileMode(options.mode, 'mode', 0o666),
);
}
Expand All @@ -2361,8 +2363,6 @@ function writeFileSync(path, data, options) {
data = Buffer.from(data, options.encoding || 'utf8');
}

const flag = options.flag || 'w';

const isUserFd = isFd(path); // File descriptor ownership
const fd = isUserFd ? path : fs.openSync(path, flag, options.mode);

Expand Down

0 comments on commit c323642

Please sign in to comment.