Skip to content

Commit

Permalink
test: refactor test-vm-static-this.js
Browse files Browse the repository at this point in the history
Remove console statements and prefer strictEqual() over equal()
in assertions.

PR-URL: #9887
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
dbradf authored and MylesBorins committed Dec 20, 2016
1 parent 9473fc6 commit c37ae4a
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions test/parallel/test-vm-static-this.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,21 @@ var vm = require('vm');

common.globalCheck = false;

console.error('run a string');
// Run a string
var result = vm.runInThisContext('\'passed\';');
assert.equal('passed', result);
assert.strictEqual('passed', result);

console.error('thrown error');
// thrown error
assert.throws(function() {
vm.runInThisContext('throw new Error(\'test\');');
}, /test/);

global.hello = 5;
vm.runInThisContext('hello = 2');
assert.equal(2, global.hello);
assert.strictEqual(2, global.hello);


console.error('pass values');
// pass values
var code = 'foo = 1;' +
'bar = 2;' +
'if (typeof baz !== \'undefined\') throw new Error(\'test fail\');';
Expand All @@ -28,11 +28,11 @@ global.obj = { foo: 0, baz: 3 };
/* eslint-disable no-unused-vars */
var baz = vm.runInThisContext(code);
/* eslint-enable no-unused-vars */
assert.equal(0, global.obj.foo);
assert.equal(2, global.bar);
assert.equal(1, global.foo);
assert.strictEqual(0, global.obj.foo);
assert.strictEqual(2, global.bar);
assert.strictEqual(1, global.foo);

console.error('call a function');
// call a function
global.f = function() { global.foo = 100; };
vm.runInThisContext('f()');
assert.equal(100, global.foo);
assert.strictEqual(100, global.foo);

0 comments on commit c37ae4a

Please sign in to comment.