Skip to content

Commit

Permalink
test: refactor test-fs-read-*
Browse files Browse the repository at this point in the history
* Use `common.mustNotCall()` in place of `common.noop` where appropriate
* Increase specificity of regular expressions (that is, make them match
  the whole error string rather than part of the error string) in
  `assert.throws()` calls

PR-URL: #13501
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
  • Loading branch information
Trott authored and addaleax committed Jun 10, 2017
1 parent bf61d97 commit c8db047
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions test/parallel/test-fs-read-file-assert-encoding.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ const encoding = 'foo-8';
const filename = 'bar.txt';

assert.throws(
fs.readFile.bind(fs, filename, { encoding }, common.noop),
new RegExp(`Error: Unknown encoding: ${encoding}$`)
fs.readFile.bind(fs, filename, { encoding }, common.mustNotCall()),
new RegExp(`^Error: Unknown encoding: ${encoding}$`)
);
6 changes: 3 additions & 3 deletions test/parallel/test-fs-read-type.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ assert.throws(() => {
expected.length,
0,
'utf-8',
common.noop);
}, /Second argument needs to be a buffer/);
common.mustNotCall());
}, /^TypeError: Second argument needs to be a buffer$/);

assert.throws(() => {
fs.readSync(fd, expected.length, 0, 'utf-8');
}, /Second argument needs to be a buffer/);
}, /^TypeError: Second argument needs to be a buffer$/);

0 comments on commit c8db047

Please sign in to comment.