n-api: create N-API version 7

Mark `napi_detach_arraybuffer` and `napi_is_detached_arraybuffer` as stable. Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: #35199 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <mdawson@devrus.com>
nodejs · Sep 21, 2020 · ca11816 · ca11816
1 parent 6119e95
commit ca11816
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 9 deletions.
diff --git a/doc/api/n-api.md b/doc/api/n-api.md
@@ -3554,10 +3554,10 @@ defined in [Section 7.2.14][] of the ECMAScript Language Specification.
 added:
  - v13.0.0
  - v12.16.0
+ - v10.22.0
+napiVersion: 7
 -->
 
-> Stability: 1 - Experimental
-
 ```c
 napi_status napi_detach_arraybuffer(napi_env env,
                                     napi_value arraybuffer)
@@ -3582,10 +3582,10 @@ defined in [Section 24.1.1.3][] of the ECMAScript Language Specification.
 added:
  - v13.3.0
  - v12.16.0
+ - v10.22.0
+napiVersion: 7
 -->
 
-> Stability: 1 - Experimental
-
 ```c
 napi_status napi_is_detached_arraybuffer(napi_env env,
                                          napi_value arraybuffer,

diff --git a/src/js_native_api.h b/src/js_native_api.h
@@ -17,7 +17,7 @@
 // functions available in a new version of N-API that is not yet ported in all
 // LTS versions, they can set NAPI_VERSION knowing that they have specifically
 // depended on that version.
-#define NAPI_VERSION 6
+#define NAPI_VERSION 7
 #endif
 #endif
 
@@ -529,14 +529,17 @@ NAPI_EXTERN napi_status napi_get_instance_data(napi_env env,
                                                void** data);
 #endif  // NAPI_VERSION >= 6
 
-#ifdef NAPI_EXPERIMENTAL
+#if NAPI_VERSION >= 7
 // ArrayBuffer detaching
 NAPI_EXTERN napi_status napi_detach_arraybuffer(napi_env env,
                                                 napi_value arraybuffer);
 
 NAPI_EXTERN napi_status napi_is_detached_arraybuffer(napi_env env,
                                                      napi_value value,
                                                      bool* result);
+#endif  // NAPI_VERSION >= 7
+
+#ifdef NAPI_EXPERIMENTAL
 // Type tagging
 NAPI_EXTERN napi_status napi_type_tag_object(napi_env env,
                                              napi_value value,

diff --git a/src/node_version.h b/src/node_version.h
@@ -93,6 +93,6 @@
 
 // The NAPI_VERSION provided by this version of the runtime. This is the version
 // which the Node binary being built supports.
-#define NAPI_VERSION  6
+#define NAPI_VERSION  7
 
 #endif  // SRC_NODE_VERSION_H_
diff --git a/test/js-native-api/test_general/test.js b/test/js-native-api/test_general/test.js
@@ -33,7 +33,7 @@ assert.notStrictEqual(test_general.testGetPrototype(baseObject),
                       test_general.testGetPrototype(extendedObject));
 
 // Test version management functions
-assert.strictEqual(test_general.testGetVersion(), 6);
+assert.strictEqual(test_general.testGetVersion(), 7);
 
 [
   123,

diff --git a/test/js-native-api/test_typedarray/test_typedarray.c b/test/js-native-api/test_typedarray/test_typedarray.c
@@ -1,4 +1,3 @@
-#define NAPI_EXPERIMENTAL
 #include <js_native_api.h>
 #include <string.h>
 #include <stdlib.h>