Review notes

nodejs · Dec 15, 2022 · ca876ad · ca876ad
1 parent 0b79ed3
commit ca876ad
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/lib/internal/modules/esm/hooks.js b/lib/internal/modules/esm/hooks.js
@@ -5,7 +5,6 @@ const {
   ArrayPrototypePush,
   FunctionPrototypeCall,
   ObjectAssign,
-  ObjectCreate,
   ObjectDefineProperty,
   ObjectSetPrototypeOf,
   SafeSet,
@@ -255,7 +254,7 @@ class Hooks {
   async resolve(
     originalSpecifier,
     parentURL,
-    importAssertions = ObjectCreate(null),
+    importAssertions = { __proto__: null },
   ) {
     const isMain = parentURL === undefined;
 
@@ -522,7 +521,7 @@ function pluckHooks({
   transformSource,
 }) {
   const obsoleteHooks = [];
-  const acceptedHooks = ObjectCreate(null);
+  const acceptedHooks = { __proto__: null };
 
   if (getGlobalPreloadCode) {
     globalPreload ??= getGlobalPreloadCode;

diff --git a/lib/internal/modules/esm/load.js b/lib/internal/modules/esm/load.js
@@ -70,7 +70,7 @@ async function getSource(url, context) {
  * @param {object} context
  * @returns {object}
  */
-async function defaultLoad(url, context) {
+async function defaultLoad(url, context = {}) {
   let responseURL = url;
   const { importAssertions } = context;
   let {

diff --git a/lib/internal/modules/esm/loader.js b/lib/internal/modules/esm/loader.js
@@ -317,7 +317,7 @@ class ESMLoader {
    * @param {object} context Metadata about the module
    * @returns {Promise<{ format: ModuleFormat, source: ModuleSource }>}
    */
-  async load(url, context = {}) {
+  async load(url, context) {
     let loadResult;
     if (this.#hooks) {
       loadResult = await this.#hooks.load(url, context);