test: improve test coverage of native crypto code

PR-URL: #25400 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs · Apr 28, 2019 · caf8965 · caf8965
1 parent 05b71f1
commit caf8965
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 0 deletions.
diff --git a/test/parallel/test-crypto-cipheriv-decipheriv.js b/test/parallel/test-crypto-cipheriv-decipheriv.js
@@ -205,3 +205,15 @@ for (let n = 1; n < 256; n += 1) {
   if (common.hasFipsCrypto && n < 12) continue;
   crypto.createCipheriv('aes-128-gcm', Buffer.alloc(16), Buffer.alloc(n));
 }
+
+{
+  // Passing an invalid cipher name should throw.
+  assert.throws(
+    () => crypto.createCipheriv('aes-127', Buffer.alloc(16), null),
+    /Unknown cipher/);
+
+  // Passing a key with an invalid length should throw.
+  assert.throws(
+    () => crypto.createCipheriv('aes-128-ecb', Buffer.alloc(17), null),
+    /Invalid key length/);
+}
diff --git a/test/parallel/test-crypto-hmac.js b/test/parallel/test-crypto-hmac.js
@@ -463,3 +463,9 @@ common.expectsError(
     assert.deepStrictEqual(h.digest('latin1'), '');
   }
 }
+
+{
+  assert.throws(
+    () => crypto.createHmac('sha7', 'key'),
+    /Unknown message digest/);
+}
diff --git a/test/parallel/test-crypto-sign-verify.js b/test/parallel/test-crypto-sign-verify.js
@@ -363,3 +363,9 @@ common.expectsError(
     assert.throws(() => verify.verify('test', input), errObj);
   });
 }
+
+{
+  assert.throws(
+    () => crypto.createSign('sha8'),
+    /Unknown message digest/);
+}