Skip to content

Commit

Permalink
net: name anonymous functions
Browse files Browse the repository at this point in the history
the changes are related #8913
regarding the naming of just the inline anonymous
functions that are not assigned to a variable

PR-URL: #9357
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
  • Loading branch information
pvsousalima authored and evanlucas committed Nov 3, 2016
1 parent e451022 commit d09eb9c
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions lib/net.js
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ function onSocketEnd() {
this.readable = false;
maybeDestroy(this);
} else {
this.once('end', function() {
this.once('end', function end() {
this.readable = false;
maybeDestroy(this);
});
Expand Down Expand Up @@ -669,7 +669,7 @@ Socket.prototype._writeGeneric = function(writev, data, encoding, cb) {
if (this.connecting) {
this._pendingData = data;
this._pendingEncoding = encoding;
this.once('connect', function() {
this.once('connect', function connect() {
this._writeGeneric(writev, data, encoding, cb);
});
return;
Expand Down Expand Up @@ -991,7 +991,7 @@ function lookupAndConnect(self, options) {
debug('connect: dns options', dnsopts);
self._host = host;
var lookup = options.lookup || dns.lookup;
lookup(host, dnsopts, function(err, ip, addressType) {
lookup(host, dnsopts, function emitLookup(err, ip, addressType) {
self.emit('lookup', err, ip, addressType, host);

// It's possible we were destroyed while looking this up.
Expand Down Expand Up @@ -1389,7 +1389,7 @@ Server.prototype.listen = function() {
};

function lookupAndListen(self, port, address, backlog, exclusive) {
require('dns').lookup(address, function(err, ip, addressType) {
require('dns').lookup(address, function doListening(err, ip, addressType) {
if (err) {
self.emit('error', err);
} else {
Expand Down Expand Up @@ -1494,7 +1494,7 @@ Server.prototype.close = function(cb) {

if (typeof cb === 'function') {
if (!this._handle) {
this.once('close', function() {
this.once('close', function close() {
cb(new Error('Not running'));
});
} else {
Expand Down

0 comments on commit d09eb9c

Please sign in to comment.