Skip to content

Commit

Permalink
build: fix make errors that occur in Makefile
Browse files Browse the repository at this point in the history
fix make errors that occur in
 coverage-clean case and coverage-test in Makefile

PR-URL: #55287
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
kmk324 authored and aduh95 committed Oct 19, 2024
1 parent bdc2c3b commit d42522e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ coverage-clean: ## Remove coverage artifacts.
$(RM) -r coverage/tmp
@if [ -d "out/Release/obj.target" ]; then \
$(FIND) out/$(BUILDTYPE)/obj.target \( -name "*.gcda" -o -name "*.gcno" \) \
-type f -exec $(RM) {};\
-type f | xargs $(RM); \
fi

.PHONY: coverage
Expand All @@ -269,7 +269,7 @@ coverage-build-js: ## Build JavaScript coverage files.
.PHONY: coverage-test
coverage-test: coverage-build ## Run the tests and generate a coverage report.
@if [ -d "out/Release/obj.target" ]; then \
$(FIND) out/$(BUILDTYPE)/obj.target -name "*.gcda" -type f -exec $(RM) {}; \
$(FIND) out/$(BUILDTYPE)/obj.target -name "*.gcda" -type f | xargs $(RM); \
fi
-NODE_V8_COVERAGE=coverage/tmp \
TEST_CI_ARGS="$(TEST_CI_ARGS) --type=coverage" $(MAKE) $(COVTESTS)
Expand Down

0 comments on commit d42522e

Please sign in to comment.