Skip to content

Commit

Permalink
fixup! src: remove dependency on wrapper-descriptor-based cpp heap
Browse files Browse the repository at this point in the history
Co-authored-by: James M Snell <jasnell@gmail.com>
  • Loading branch information
joyeecheung and jasnell authored May 30, 2024
1 parent 1a14799 commit d48d61a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/env.cc
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#include "util-inl.h"
#include "v8-cppgc.h"
#include "v8-profiler.h"
#include "v8-sandbox.h"
#include "v8-sandbox.h" // v8::Object::Wrap(), v8::Object::Unwrap()

#include <algorithm>
#include <atomic>
Expand Down Expand Up @@ -524,7 +524,7 @@ void IsolateData::CreateProperties() {
// the ecosystem is:
// [ 0 ] -> embedder id
// [ 1 ] -> wrappable instance
// Now V8 has deprecated this layout-based tracing enablement, embeders
// Now V8 has deprecated this layout-based tracing enablement, embedders
// should simply use v8::Object::Wrap() and v8::Object::Unwrap(). We preserve
// this layout only to distinguish internally how the memory of a Node.js
// wrapper is managed or whether a wrapper is managed by Node.js.
Expand Down

0 comments on commit d48d61a

Please sign in to comment.