Skip to content

Commit

Permalink
module: fix recently introduced coverity warning
Browse files Browse the repository at this point in the history
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #50843
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
mhdawson committed Dec 4, 2023
1 parent cd71838 commit d4bcdd8
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/node_modules.cc
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,10 @@ const BindingData::PackageConfig* BindingData::GetPackageJSON(
return throw_invalid_package_config();
}

// based on coverity using key with == derefs the raw value
// avoid derefing if its null
if (key.raw() == nullptr) continue;

if (key == "name") {
// Though there is a key "name" with a corresponding value,
// the value may not be a string or could be an invalid JSON string
Expand Down

0 comments on commit d4bcdd8

Please sign in to comment.