Skip to content

Commit

Permalink
build: don't pass --mode argument to V8 test-runner
Browse files Browse the repository at this point in the history
V8's test-runner dropped the `--mode` argument some time back, and now
produces the following error if run with it:
  run-tests.py: error: no such option: --mode

PR-URL: #39055
Refs: #35705
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
richardlau authored and nodejs-github-bot committed Jun 23, 2021
1 parent bf9ce95 commit d65514b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -667,12 +667,12 @@ test-v8: v8 ## Runs the V8 test suite on deps/v8.
test-v8-intl: v8
export PATH="$(NO_BIN_OVERRIDE_PATH)" && \
deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \
--mode=$(BUILDTYPE_LOWER) intl \
intl \
$(TAP_V8_INTL)

test-v8-benchmarks: v8
export PATH="$(NO_BIN_OVERRIDE_PATH)" && \
deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) --mode=$(BUILDTYPE_LOWER) \
deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \
benchmarks \
$(TAP_V8_BENCHMARKS)

Expand Down

0 comments on commit d65514b

Please sign in to comment.