Skip to content

Commit

Permalink
build: do not lint src dir for JS errors
Browse files Browse the repository at this point in the history
There are no JavaScript files in the `src` directory. It can be
safely omitted from the JavaScript linting step.

PR-URL: #8128
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Trott committed Aug 18, 2016
1 parent 1d0385f commit dbbbf21
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -671,11 +671,11 @@ bench: bench-net bench-http bench-fs bench-tls
bench-ci: bench

jslint:
$(NODE) tools/jslint.js -J benchmark lib src test tools
$(NODE) tools/jslint.js -J benchmark lib test tools

jslint-ci:
$(NODE) tools/jslint.js $(PARALLEL_ARGS) -f tap -o test-eslint.tap \
benchmark lib src test tools
benchmark lib test tools

CPPLINT_EXCLUDE ?=
CPPLINT_EXCLUDE += src/node_root_certs.h
Expand Down
4 changes: 2 additions & 2 deletions vcbuild.bat
Original file line number Diff line number Diff line change
Expand Up @@ -351,12 +351,12 @@ if defined jslint_ci goto jslint-ci
if not defined jslint goto exit
if not exist tools\eslint\lib\eslint.js goto no-lint
echo running jslint
%config%\node tools\jslint.js -J benchmark lib src test tools
%config%\node tools\jslint.js -J benchmark lib test tools
goto exit

:jslint-ci
echo running jslint-ci
%config%\node tools\jslint.js -J -f tap -o test-eslint.tap benchmark lib src test tools
%config%\node tools\jslint.js -J -f tap -o test-eslint.tap benchmark lib test tools
goto exit

:no-lint
Expand Down

0 comments on commit dbbbf21

Please sign in to comment.