Skip to content

Commit

Permalink
deps: V8: cherry-pick 3cab84c24723
Browse files Browse the repository at this point in the history
Original commit message:

    [riscv64] Use s1 to save code_obj

    The caller saved a4 may be clobbered by the callee function.
    So we substitute it with the callee saved s1 to save code_obj.

    Change-Id: Iebe707cbaa62d47fdee0aa117e32e88f67dac743
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3096886
    Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
    Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
    Commit-Queue: Yahan Lu <yahan@iscas.ac.cn>
    Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/master@{#76294}

Refs:  v8/v8@3cab84c2472

PR-URL: #41566
Refs: v8/v8@d8dc66f
Refs: v8/v8@3cab84c
Refs: v8/v8@471f862
Refs: v8/v8@77599ff
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
luyahan authored and danielleadams committed Jan 30, 2022
1 parent e391da4 commit dc6843c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.15',
'v8_embedder_string': '-node.16',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/builtins/riscv64/builtins-riscv64.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3642,7 +3642,7 @@ void Generate_BaselineOrInterpreterEntry(MacroAssembler* masm,
__ Ld(closure, MemOperand(fp, StandardFrameConstants::kFunctionOffset));

// Get the Code object from the shared function info.
Register code_obj = a4;
Register code_obj = s1;
__ LoadTaggedPointerField(
code_obj,
FieldMemOperand(closure, JSFunction::kSharedFunctionInfoOffset));
Expand Down

0 comments on commit dc6843c

Please sign in to comment.