[v16.x] deps: V8: cherry-pick d8dc66f #41566

luyahan · 2022-01-17T08:00:35Z

Fix riscv64 segment fault
origin commit :

[riscv64][sparkplug] Fix sparkplug verify framesize failed

Change-Id: I7481749ba3d5c41d7405b0d88a51defbc8bec9d6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093009
Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
Commit-Queue: Yahan Lu <yahan@iscas.ac.cn>
Cr-Commit-Position: refs/heads/master@{#76277}

Refs: v8/v8@d8dc66f

[riscv64] Use s1 to save code_obj

The caller saved a4 may be clobbered by the callee function. So we substitute it with the callee saved s1 to save code_obj.

Change-Id: Iebe707cbaa62d47fdee0aa117e32e88f67dac743
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3096886
Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
Commit-Queue: Yahan Lu <yahan@iscas.ac.cn>
Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
Cr-Commit-Position: refs/heads/master@{#76294}

Refs: v8/v8@3cab84c

[riscv64] Link should greater and equal zero

Change-Id: Ieeb5888efc068707766aef6ba6fc842c5deaaf9c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3146673
Commit-Queue: Yahan Lu <yahan@iscas.ac.cn>
Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#76784}

Refs: v8/v8@471f862

[riscv64] Add block before LoadAddress

fix node.js DCHECK failed
issue: https://github.com/riscv-collab/v8/issues/514

Change-Id: I07f40e6aca05be3eb7304a43235185fd40ebc1f2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260979
Reviewed-by: ji qiu <qiuji@iscas.ac.cn>
Commit-Queue: ji qiu <qiuji@iscas.ac.cn>
Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#77750}

Refs: v8/v8@77599ff

nodejs-github-bot · 2022-01-17T08:00:42Z

Review requested:

@nodejs/actions
@nodejs/tsc

luyahan · 2022-01-17T08:02:00Z

Reland #41564 @gengjiawen @targos

targos · 2022-01-17T08:02:56Z

@luyahan do you target v16.x-staging because the fixes are already in v17.x ?

luyahan · 2022-01-17T08:05:27Z

@luyahan do you target v16.x-staging because the fixes are already in v17.x ?

Yes.

Original commit message: [riscv64][sparkplug] Fix sparkplug verify framesize failed Change-Id: I7481749ba3d5c41d7405b0d88a51defbc8bec9d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093009 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/master@{#76277} Refs: v8/v8@d8dc66f9

Original commit message: [riscv64] Use s1 to save code_obj The caller saved a4 may be clobbered by the callee function. So we substitute it with the callee saved s1 to save code_obj. Change-Id: Iebe707cbaa62d47fdee0aa117e32e88f67dac743 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3096886 Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/master@{#76294} Refs: v8/v8@3cab84c2472

Original commit message: [riscv64] Link should greater and equal zero Change-Id: Ieeb5888efc068707766aef6ba6fc842c5deaaf9c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3146673 Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#76784} Refs: v8/v8@471f862954f3

Original commit message: [sparkplug] Simplify arch-guards to ENABLE_SPARKPLUG There is still a place to simplify. Bug: v8:11420, v8:11421 Change-Id: I774139c52d911323f162350532a493e70f518643 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3096885 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#76296} Refs: v8/v8@e74d6918fb9

Original commit message: [riscv64] Add block before LoadAddress fix node.js DCHECK failed issue: riscv-collab/v8#514 Change-Id: I07f40e6aca05be3eb7304a43235185fd40ebc1f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260979 Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#77750} Refs: v8/v8@77599ffe0a74

nodejs-github-bot · 2022-01-17T13:21:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/41940/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/4472/ (✔️)

nodejs-github-bot · 2022-01-17T17:31:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/41957/

luyahan · 2022-01-18T01:38:30Z

How to fix this https://ci.nodejs.org/job/node-test-commit/51132/console?
I can't understand this output.

nodejs-github-bot · 2022-01-18T11:46:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/41982/

nodejs-github-bot · 2022-01-18T12:01:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/41983/

nodejs-github-bot · 2022-01-18T12:16:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/41985/

nodejs-github-bot · 2022-01-18T13:32:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/41988/

nodejs-github-bot · 2022-01-18T15:21:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/41993/ (✔️)

XieJiSS · 2022-01-19T11:58:54Z

How to fix this https://ci.nodejs.org/job/node-test-commit/51132/console? I can't understand this output.

@luyahan Seems like a test case is failing: https://ci.nodejs.org/job/node-test-binary-windows-js-suites/RUN_SUBSET=1,nodes=win10-COMPILED_BY-vs2019/13158/console

That's strange, because this PR does not mess up with those Windows stuff.

richardlau · 2022-01-19T12:07:46Z

How to fix this https://ci.nodejs.org/job/node-test-commit/51132/console? I can't understand this output.

@luyahan Seems like a test case is failing: https://ci.nodejs.org/job/node-test-binary-windows-js-suites/RUN_SUBSET=1,nodes=win10-COMPILED_BY-vs2019/13158/console

You can ignore that one as it's a known flake #40728. The last CI (https://ci.nodejs.org/job/node-test-pull-request/41993/) passed.

danielleadams · 2022-01-29T01:45:50Z

@luyahan @targos @richardlau what is the status of this? Does this need to be backported to include the base branch/PR metadata, or can we pull this into the next 16.x as is?

targos · 2022-01-29T10:45:19Z

@danielleadams the changes only apply to v16.x, so we should directly pull this into the next release.

Original commit message: [riscv64][sparkplug] Fix sparkplug verify framesize failed Change-Id: I7481749ba3d5c41d7405b0d88a51defbc8bec9d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093009 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/master@{#76277} Refs: v8/v8@d8dc66f9 PR-URL: #41566 Refs: v8/v8@d8dc66f Refs: v8/v8@3cab84c Refs: v8/v8@471f862 Refs: v8/v8@77599ff Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Original commit message: [riscv64] Use s1 to save code_obj The caller saved a4 may be clobbered by the callee function. So we substitute it with the callee saved s1 to save code_obj. Change-Id: Iebe707cbaa62d47fdee0aa117e32e88f67dac743 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3096886 Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/master@{#76294} Refs: v8/v8@3cab84c2472 PR-URL: #41566 Refs: v8/v8@d8dc66f Refs: v8/v8@3cab84c Refs: v8/v8@471f862 Refs: v8/v8@77599ff Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Original commit message: [riscv64] Link should greater and equal zero Change-Id: Ieeb5888efc068707766aef6ba6fc842c5deaaf9c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3146673 Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#76784} Refs: v8/v8@471f862954f3 PR-URL: #41566 Refs: v8/v8@d8dc66f Refs: v8/v8@3cab84c Refs: v8/v8@471f862 Refs: v8/v8@77599ff Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Original commit message: [sparkplug] Simplify arch-guards to ENABLE_SPARKPLUG There is still a place to simplify. Bug: v8:11420, v8:11421 Change-Id: I774139c52d911323f162350532a493e70f518643 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3096885 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#76296} Refs: v8/v8@e74d6918fb9 PR-URL: #41566 Refs: v8/v8@d8dc66f Refs: v8/v8@3cab84c Refs: v8/v8@471f862 Refs: v8/v8@77599ff Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Original commit message: [riscv64] Add block before LoadAddress fix node.js DCHECK failed issue: riscv-collab/v8#514 Change-Id: I07f40e6aca05be3eb7304a43235185fd40ebc1f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260979 Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#77750} Refs: v8/v8@77599ffe0a74 PR-URL: #41566 Refs: v8/v8@d8dc66f Refs: v8/v8@3cab84c Refs: v8/v8@471f862 Refs: v8/v8@77599ff Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

danielleadams · 2022-01-30T02:43:02Z

Landed in 9e68c00...036650e

luyahan changed the base branch from master to v16.x-staging January 17, 2022 08:00

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jan 17, 2022

luyahan mentioned this pull request Jan 17, 2022

deps: V8: cherry-pick d8dc66f 3cab84c 471f862 77599ff #41564

Closed

luyahan changed the title ~~deps: V8: cherry-pick d8dc66f 3cab84c 471f862 77599ff~~ deps: V8: cherry-pick Jan 17, 2022

luyahan changed the title ~~deps: V8: cherry-pick~~ deps: V8: cherry-pick d8dc66f Jan 17, 2022

luyahan added 5 commits January 17, 2022 18:22

luyahan force-pushed the v16.x-staging branch from a4fb9ee to f18bb63 Compare January 17, 2022 10:25

luyahan changed the title ~~deps: V8: cherry-pick d8dc66f~~ deps: V8: cherry-pick d8dc66f Jan 17, 2022

gengjiawen approved these changes Jan 17, 2022

View reviewed changes

gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2022

github-actions bot mentioned this pull request Jan 18, 2022

CI Reliability 2022-01-18 nodejs/reliability#175

Open

16 tasks

targos changed the title ~~deps: V8: cherry-pick d8dc66f~~ [v16.x] deps: V8: cherry-pick d8dc66f Jan 18, 2022

targos added the v16.x label Jan 18, 2022

github-actions bot mentioned this pull request Jan 19, 2022

CI Reliability 2022-01-19 nodejs/reliability#176

Open

13 tasks

github-actions bot mentioned this pull request Jan 20, 2022

CI Reliability 2022-01-20 nodejs/reliability#177

Open

17 tasks

XieJiSS mentioned this pull request Jan 20, 2022

[Feature Request]: Possible RISC-V Support electron/electron#32551

Closed

3 tasks

This was referenced Jan 21, 2022

CI Reliability 2022-01-21 nodejs/reliability#178

Open

CI Reliability 2022-01-22 nodejs/reliability#179

Open

targos added dont-land-on-v12.x labels Jan 29, 2022

targos approved these changes Jan 29, 2022

View reviewed changes

danielleadams closed this Jan 30, 2022

danielleadams added the backported-to-v16.x label Jan 30, 2022

danielleadams mentioned this pull request Feb 1, 2022

v16.14.0 proposal #41804

Merged

XieJiSS mentioned this pull request Mar 29, 2022

upgpkg: nodejs-lts-gallium felixonmars/archriscv-packages#1006

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v16.x] deps: V8: cherry-pick d8dc66f #41566

[v16.x] deps: V8: cherry-pick d8dc66f #41566

luyahan commented Jan 17, 2022

nodejs-github-bot commented Jan 17, 2022

luyahan commented Jan 17, 2022 •

edited

Loading

targos commented Jan 17, 2022

luyahan commented Jan 17, 2022

nodejs-github-bot commented Jan 17, 2022 •

edited by richardlau

Loading

nodejs-github-bot commented Jan 17, 2022

luyahan commented Jan 18, 2022

nodejs-github-bot commented Jan 18, 2022

nodejs-github-bot commented Jan 18, 2022

nodejs-github-bot commented Jan 18, 2022

nodejs-github-bot commented Jan 18, 2022

nodejs-github-bot commented Jan 18, 2022 •

edited by richardlau

Loading

XieJiSS commented Jan 19, 2022 •

edited

Loading

richardlau commented Jan 19, 2022

danielleadams commented Jan 29, 2022

targos commented Jan 29, 2022

danielleadams commented Jan 30, 2022

[v16.x] deps: V8: cherry-pick d8dc66f #41566

[v16.x] deps: V8: cherry-pick d8dc66f #41566

Conversation

luyahan commented Jan 17, 2022

nodejs-github-bot commented Jan 17, 2022

luyahan commented Jan 17, 2022 • edited Loading

targos commented Jan 17, 2022

luyahan commented Jan 17, 2022

nodejs-github-bot commented Jan 17, 2022 • edited by richardlau Loading

nodejs-github-bot commented Jan 17, 2022

luyahan commented Jan 18, 2022

nodejs-github-bot commented Jan 18, 2022

nodejs-github-bot commented Jan 18, 2022

nodejs-github-bot commented Jan 18, 2022

nodejs-github-bot commented Jan 18, 2022

nodejs-github-bot commented Jan 18, 2022 • edited by richardlau Loading

XieJiSS commented Jan 19, 2022 • edited Loading

richardlau commented Jan 19, 2022

danielleadams commented Jan 29, 2022

targos commented Jan 29, 2022

danielleadams commented Jan 30, 2022

luyahan commented Jan 17, 2022 •

edited

Loading

nodejs-github-bot commented Jan 17, 2022 •

edited by richardlau

Loading

nodejs-github-bot commented Jan 18, 2022 •

edited by richardlau

Loading

XieJiSS commented Jan 19, 2022 •

edited

Loading