move check to connect function

nodejs · Jun 16, 2017 · dcb6cde · dcb6cde
1 parent a4d753f
commit dcb6cde
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/lib/net.js b/lib/net.js
@@ -873,10 +873,6 @@ function internalConnect(
 
   var err;
 
-  if (typeof address !== 'string') {
-    throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'address', 'string');
-  }
-
   if (localAddress || localPort) {
     debug('binding to localAddress: %s and localPort: %d (addressType: %d)',
           localAddress, localPort, addressType);
@@ -969,8 +965,9 @@ Socket.prototype.connect = function() {
     this._sockname = null;
   }
 
-  var pipe = !!options.path;
-  debug('pipe', pipe, options.path);
+  const path = options.path;
+  var pipe = !!path;
+  debug('pipe', pipe, path);
 
   if (!this._handle) {
     this._handle = pipe ? new Pipe() : new TCP();
@@ -987,7 +984,10 @@ Socket.prototype.connect = function() {
   this.writable = true;
 
   if (pipe) {
-    internalConnect(this, options.path);
+    if (typeof path !== 'string') {
+      throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'options.path', 'string', path);
+    }
+    internalConnect(this, path);
   } else {
     lookupAndConnect(this, options);
   }