Skip to content

Commit

Permalink
buffer: faster case for create buffer from empty string
Browse files Browse the repository at this point in the history
When create Buffer from empty string will touch
C++ binding also.

This patch can improve edge case ~70% faster.
  • Loading branch information
JacksonTian committed Mar 23, 2016
1 parent 8baaa25 commit de8f36d
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 5 deletions.
15 changes: 10 additions & 5 deletions benchmark/buffers/buffer_zero.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,21 @@
const common = require('../common.js');

const bench = common.createBenchmark(main, {
n: [1024]
n: [1024],
type: ['buffer', 'string']
});

const zero = Buffer.alloc(0);
const zeroBuffer = Buffer.alloc(0);
const zeroString = '';

function main(conf) {
var n = +conf.n;
bench.start();
for (let i = 0; i < n * 1024; i++) {
Buffer.from(zero);
}

if (conf.type === 'buffer')
for (let i = 0; i < n * 1024; i++) Buffer.from(zeroBuffer);
else if (conf.type === 'string')
for (let i = 0; i < n * 1024; i++) Buffer.from(zeroString);

bench.end(n);
}
4 changes: 4 additions & 0 deletions lib/buffer.js
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,10 @@ function fromString(string, encoding) {
throw new TypeError('"encoding" must be a valid string encoding');

var length = byteLength(string, encoding);

if (length === 0)
return Buffer.alloc(0);

if (length >= (Buffer.poolSize >>> 1))
return binding.createFromString(string, encoding);

Expand Down

0 comments on commit de8f36d

Please sign in to comment.