Skip to content

Commit e03be6b

Browse files
StefanStojanovicaduh95
authored andcommitted
build: avoid compiling with VS v17.12
Refs: nodejs/build#3963 PR-URL: #55930 Refs: #53863 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 216a785 commit e03be6b

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

vcbuild.bat

+10-1
Original file line numberDiff line numberDiff line change
@@ -290,10 +290,19 @@ goto exit
290290
@rem Visual Studio v17.10 has a bug that causes the build to fail.
291291
@rem Check if the version is v17.10 and exit if it is.
292292
echo %VSCMD_VER% | findstr /b /c:"17.10" >nul
293-
if %errorlevel% neq 1 (
293+
if %errorlevel% neq 1 (
294294
echo Node.js doesn't compile with Visual Studio 17.10 Please use a different version.
295295
goto exit
296296
)
297+
@rem Same applies to v17.12 for MSVC.
298+
echo %VSCMD_VER% | findstr /b /c:"17.12" >nul
299+
if %errorlevel% neq 1 (
300+
@rem Clang 18.1.8 Provided with VS 17.12 works fine.
301+
if not defined clang_cl (
302+
echo Node.js doesn't compile with Visual Studio 17.12 Please use a different version.
303+
goto exit
304+
)
305+
)
297306

298307
@rem check if the clang-cl build is requested
299308
if not defined clang_cl goto clang-skip

0 commit comments

Comments
 (0)