Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: avoid compiling with VS v17.10 #53863

Merged
merged 2 commits into from
Jul 25, 2024
Merged

build: avoid compiling with VS v17.10 #53863

merged 2 commits into from
Jul 25, 2024

Conversation

huseyinacacak-janea
Copy link
Contributor

Visual Studio v17.10 has a bug that produces a compilation error.

Refs: nodejs/build#3739

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform. labels Jul 16, 2024
@StefanStojanovic
Copy link
Contributor

Since I'm working with Huseyin, let me give more context here.

So, the motivation for this PR is to give people trying to compile Node.js on Windows, clear information about why it is failing. Currently, they have to go to the build repository to find the issue there and go through all the comments. This way it is much easier to know what happened. Once this is fixed in the current version, or a new one that is not working is released, there'll be PRs to make the changes needed to stay up to date.

There's also a patch we could include, but that way we'll not know when MSVC is fixed, so I'm not really for that at this time, especially since we already have Jenkins machines working, but I'm open for any suggestion and discussion.

@targos
Copy link
Member

targos commented Jul 16, 2024

@StefanStojanovic You told me you were in contact with someone from the MSVC team (or at least from Microsoft). Do you know why it's taking so long to release the fix in Visual Studio?

richardlau
richardlau reviewed Jul 16, 2024
View reviewed changes
vcbuild.bat Outdated Show resolved Hide resolved
@huseyinacacak-janea @richardlau
Update vcbuild.bat
48ec713 
Co-authored-by: Richard Lau <rlau@redhat.com>
@Flarna Flarna added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60615/

@Flarna Flarna added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 25, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 25, 2024
@nodejs-github-bot nodejs-github-bot merged commit 852a1a6 into nodejs:main Jul 25, 2024
57 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 852a1a6

@richardlau richardlau mentioned this pull request Jul 25, 2024
Open
targos pushed a commit that referenced this pull request Jul 28, 2024
@huseyinacacak-janea @targos
build: avoid compiling with VS v17.10
a423344 
Refs: nodejs/build#3739
PR-URL: #53863
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@RafaelGSS RafaelGSS mentioned this pull request Jul 30, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 5, 2024
@huseyinacacak-janea @RafaelGSS
build: avoid compiling with VS v17.10
7c417c6 
Refs: nodejs/build#3739
PR-URL: #53863
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
tdtc-hrb added a commit to tdtc-hrb/Cps_dotnet-core that referenced this pull request Aug 16, 2024
@tdtc-hrb
Visual Studio v17.10 has a bug that produces a compilation error.
b4b01e7 
[#53863](nodejs/node#53863)
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
This was referenced Nov 20, 2024
Open
Merged
nodejs-github-bot pushed a commit that referenced this pull request Nov 26, 2024
@StefanStojanovic
build: avoid compiling with VS v17.12
542f252 
Refs: nodejs/build#3963
PR-URL: #55930
Refs: #53863
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Nov 26, 2024
@StefanStojanovic @aduh95
build: avoid compiling with VS v17.12
7133c04 
Refs: nodejs/build#3963
PR-URL: #55930
Refs: #53863
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau left review comments

@Flarna Flarna Flarna approved these changes

@targos targos targos approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@huseyinacacak-janea @StefanStojanovic @targos @nodejs-github-bot @anonrig @richardlau @Flarna