build: avoid compiling with VS v17.10 #53863
Conversation
nodejs-github-bot
added
build
|
Since I'm working with Huseyin, let me give more context here. So, the motivation for this PR is to give people trying to compile Node.js on Windows, clear information about why it is failing. Currently, they have to go to the build repository to find the issue there and go through all the comments. This way it is much easier to know what happened. Once this is fixed in the current version, or a new one that is not working is released, there'll be PRs to make the changes needed to stay up to date. There's also a patch we could include, but that way we'll not know when MSVC is fixed, so I'm not really for that at this time, especially since we already have Jenkins machines working, but I'm open for any suggestion and discussion. |
|
@StefanStojanovic You told me you were in contact with someone from the MSVC team (or at least from Microsoft). Do you know why it's taking so long to release the fix in Visual Studio? |
Co-authored-by: Richard Lau <rlau@redhat.com>
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Flarna
added
commit-queue-squash
nodejs-github-bot
removed
the
commit-queue
|
Landed in 852a1a6 |
Refs: nodejs/build#3739 PR-URL: #53863 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Refs: nodejs/build#3739 PR-URL: #53863 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
targos
added
the
dont-land-on-v20.x
Visual Studio v17.10 has a bug that produces a compilation error.
Refs: nodejs/build#3739