tools: fix more build warnings in inspector_protocol

nodejs · Aug 10, 2021 · e79973c · e79973c
1 parent 1c2c34a
commit e79973c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/tools/inspector_protocol/encoding/encoding.cc b/tools/inspector_protocol/encoding/encoding.cc
@@ -850,8 +850,9 @@ void CBORTokenizer::ReadNextToken(bool enter_envelope) {
  // We check the the payload in token_start_internal_value_ against
  // that range (2^31-1 is also known as
  // std::numeric_limits<int32_t>::max()).
- if (!bytes_read || token_start_internal_value_ >
- std::numeric_limits<int32_t>::max()) {
+ if (!bytes_read ||
+ static_cast<int64_t>(token_start_internal_value_) >
+ static_cast<int64_t>(std::numeric_limits<int32_t>::max())) {
  SetError(Error::CBOR_INVALID_INT32);
  return;
  }

diff --git a/tools/inspector_protocol/lib/encoding_cpp.template b/tools/inspector_protocol/lib/encoding_cpp.template
@@ -858,8 +858,9 @@ void CBORTokenizer::ReadNextToken(bool enter_envelope) {
  // We check the the payload in token_start_internal_value_ against
  // that range (2^31-1 is also known as
  // std::numeric_limits<int32_t>::max()).
- if (!bytes_read || token_start_internal_value_ >
- std::numeric_limits<int32_t>::max()) {
+ if (!bytes_read ||
+ static_cast<int64_t>(token_start_internal_value_) >
+ static_cast<int64_t>(std::numeric_limits<int32_t>::max())) {
  SetError(Error::CBOR_INVALID_INT32);
  return;
  }