Skip to content

Commit

Permalink
build: add flag to build V8 with OBJECT_PRINT
Browse files Browse the repository at this point in the history
Add a configure flag to build V8 with `-DOBJECT_PRINT`, which will
expose auxiliar functions to inspect heap objects using native
debuggers.

Fixes: #32402
Signed-off-by: Mary Marchini <mmarchini@netflix.com>

PR-URL: #32834
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
  • Loading branch information
mmarchini authored and addaleax committed Sep 22, 2020
1 parent 2260037 commit ee49813
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -648,6 +648,12 @@
'memory footprint, but also implies no just-in-time compilation ' +
'support, thus much slower execution)')

parser.add_option('--v8-enable-object-print',
action='store_true',
dest='v8_enable_object_print',
default=False,
help='compile V8 with auxiliar functions for native debuggers')

parser.add_option('--node-builtin-modules-path',
action='store',
dest='node_builtin_modules_path',
Expand Down Expand Up @@ -1251,6 +1257,7 @@ def configure_v8(o):
o['variables']['v8_no_strict_aliasing'] = 1 # Work around compiler bugs.
o['variables']['v8_optimized_debug'] = 0 if options.v8_non_optimized_debug else 1
o['variables']['dcheck_always_on'] = 1 if options.v8_with_dchecks else 0
o['variables']['v8_enable_object_print'] = 1 if options.v8_enable_object_print else 0
o['variables']['v8_random_seed'] = 0 # Use a random seed for hash tables.
o['variables']['v8_promise_internal_field_count'] = 1 # Add internal field to promises for async hooks.
o['variables']['v8_use_siphash'] = 0 if options.without_siphash else 1
Expand Down

0 comments on commit ee49813

Please sign in to comment.