Skip to content

Commit

Permalink
test: dynamic port in cluster ipc throw
Browse files Browse the repository at this point in the history
Removed common.PORT from test-cluster-ipc-throw to eliminate the
possibility that a dynamic port used in another test will collide
with common.PORT.

PR-URL: #12571
Ref: #12376
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Sebastian Plesciuc authored and jasnell committed Apr 24, 2017
1 parent c005ebb commit ee8183e
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions test/parallel/test-cluster-ipc-throw.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,23 @@
const common = require('../common');
const http = require('http');
const cluster = require('cluster');
const assert = require('assert');

cluster.schedulingPolicy = cluster.SCHED_RR;

const server = http.createServer();

if (cluster.isMaster) {
server.listen(common.PORT);
const worker = cluster.fork();
worker.on('exit', common.mustCall(() => {
server.close();
server.listen({port: 0}, common.mustCall(() => {
const worker = cluster.fork({PORT: server.address().port});
worker.on('exit', common.mustCall(() => {
server.close();
}));
}));
} else {
assert(process.env.PORT);
process.on('uncaughtException', common.mustCall((e) => {}));
server.listen(common.PORT);
server.listen(process.env.PORT);
server.on('error', common.mustCall((e) => {
cluster.worker.disconnect();
throw e;
Expand Down

0 comments on commit ee8183e

Please sign in to comment.