Skip to content

Commit

Permalink
http: disallow sending obviously invalid status codes
Browse files Browse the repository at this point in the history
Back port of
7e9b0dd
to v0.12

PR-URL: nodejs-private/node-private#48
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
  • Loading branch information
evanlucas authored and rvagg committed Sep 27, 2016
1 parent 1cbdb19 commit f243343
Show file tree
Hide file tree
Showing 2 changed files with 96 additions and 0 deletions.
4 changes: 4 additions & 0 deletions lib/http.js
Original file line number Diff line number Diff line change
Expand Up @@ -1229,6 +1229,10 @@ ServerResponse.prototype.writeHead = function(statusCode) {
headers = obj;
}

statusCode |= 0;
if (statusCode < 100 || statusCode > 999)
throw new RangeError('Invalid status code: ' + statusCode);

var statusLine = 'HTTP/1.1 ' + statusCode.toString() + ' ' +
reasonPhrase + CRLF;

Expand Down
92 changes: 92 additions & 0 deletions test/simple/test-http-response-statuscode.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
'use strict';
var common = require('../common');
var assert = require('assert');
var http = require('http');

var MAX_REQUESTS = 12;
var reqNum = 0;

var server = http.Server(common.mustCall(function(req, res) {
switch (reqNum) {
case 0:
assert.throws(common.mustCall(function() {
res.writeHead(-1);
}, /invalid status code/i));
break;
case 1:
assert.throws(common.mustCall(function() {
res.writeHead(Infinity);
}, /invalid status code/i));
break;
case 2:
assert.throws(common.mustCall(function() {
res.writeHead(NaN);
}, /invalid status code/i));
break;
case 3:
assert.throws(common.mustCall(function() {
res.writeHead({});
}, /invalid status code/i));
break;
case 4:
assert.throws(common.mustCall(function() {
res.writeHead(99);
}, /invalid status code/i));
break;
case 5:
assert.throws(common.mustCall(function() {
res.writeHead(1000);
}, /invalid status code/i));
break;
case 6:
assert.throws(common.mustCall(function() {
res.writeHead('1000');
}, /invalid status code/i));
break;
case 7:
assert.throws(common.mustCall(function() {
res.writeHead(null);
}, /invalid status code/i));
break;
case 8:
assert.throws(common.mustCall(function() {
res.writeHead(true);
}, /invalid status code/i));
break;
case 9:
assert.throws(common.mustCall(function() {
res.writeHead([]);
}, /invalid status code/i));
break;
case 10:
assert.throws(common.mustCall(function() {
res.writeHead('this is not valid');
}, /invalid status code/i));
break;
case 11:
assert.throws(common.mustCall(function() {
res.writeHead('404 this is not valid either');
}, /invalid status code/i));
this.close();
break;
default:
throw new Error('Unexpected request');
}
res.statusCode = 200;
res.end();
}, MAX_REQUESTS));
server.listen();

server.on('listening', function makeRequest() {
var self = this;
http.get({
port: self.address().port
}, function(res) {
assert.strictEqual(res.statusCode, 200);
res.on('end', function() {
if (++reqNum < MAX_REQUESTS)
makeRequest.call(self);
});
res.resume();
});
});

0 comments on commit f243343

Please sign in to comment.