Skip to content

Commit

Permalink
test: use descriptive names for regression tests
Browse files Browse the repository at this point in the history
Rename the tests appropriately alongside mentioning the subsystem.
Also, make a few basic changes to make sure the tests conform to the
standard test structure.

- Rename test-regress-GH-9819 to test-crypto-tostring-segfault
- Rename test-regress-GH-5051 to test-http-addrequest-localaddress
- Rename test-regress-GH-5727 to test-net-listen-invalid-port
- Rename test-regress-GH-5927 to test-tty-stdin-pipe
- Rename test-regress-GH-6235 to test-v8-global-setter

PR-URL: #19275
Refs: #19105
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
ryzokuken authored and MylesBorins committed Mar 20, 2018
1 parent b229912 commit f490421
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');

// This test ensures that node doesn't SEGFAULT when either of
// `crypto.createHash` or `crypto.createHmac` are given an object that defines
// a throwing `toString`.
// https://github.com/nodejs/node/issues/9819

const assert = require('assert');
const execFile = require('child_process').execFile;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
'use strict';
require('../common');

// This test ensures that `addRequest`'s Legacy API accepts `localAddress`
// correctly instead of accepting `path`.
// https://github.com/nodejs/node/issues/5051

const assert = require('assert');
const agent = require('http').globalAgent;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
'use strict';
const common = require('../common');

// This test ensures that port numbers are validated in *all* kinds of `listen`
// calls. If an invalid port is supplied, ensures a `RangeError` is thrown.
// https://github.com/nodejs/node/issues/5727

const assert = require('assert');
const net = require('net');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@

'use strict';
require('../common');

// This test ensures piping from `stdin` isn't broken.
// https://github.com/nodejs/node/issues/5927

const assert = require('assert');
const readline = require('readline');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,9 @@ const assert = require('assert');
assert.doesNotThrow(function() {
require('vm').runInNewContext('"use strict"; var v = 1; v = 2');
});

// This test ensures v8 correctly sets a property on the global object if it
// has a setter interceptor in strict mode.
// https://github.com/nodejs/node-v0.x-archive/issues/6235

require('vm').runInNewContext('"use strict"; var v = 1; v = 2');

0 comments on commit f490421

Please sign in to comment.