util: deprecate most of util.is*() #6235

Fishrock123 · 2016-04-15T20:34:47Z

Checklist

tests and code linting passes
a test and/or benchmark is included
documentation is changed or added
the commit message follows commit guidelines

Affected core subsystem(s)

util

Description of change

Supersedes #1301

This deprecates most of util.is except some stuff for which v8 has internal functions for and primitives.

To be quite honest, I don't really know what to do here, if this is remotely right, etc.

cc @nodejs/ctc I guess

note: the tests currently log a ton of warnings but I can't be bothered to fix them until we decide on what is the best path forward

mscdex · 2016-04-15T20:38:24Z

lib/util.js

-exports.isNullOrUndefined = isNullOrUndefined;
+exports.isNullOrUndefined = internalUtil.deprecate(isNullOrUndefined,
+  'util.isNullOrUndefined() is deprecated. Use the following instead:\n' +
+  'arg === null || arg === undefined');


or arg == null

+1 on == null. Last I looked at the optimizing compiler nullOrUndefined is special cased.

jasnell · 2016-04-15T21:12:01Z

LGTM

Fishrock123 · 2016-04-19T04:47:37Z

Still not convinced this is actually 100% the right thing to do fwiw

mscdex · 2016-04-19T05:30:51Z

@Fishrock123 You mean in general or specifically the c++ IsPrimitive() implementation?

Fishrock123 · 2016-04-20T04:42:40Z

@mscdex both, any of the above

jasnell · 2016-04-30T05:30:59Z

lib/util.js

-exports.isFunction = isFunction;
+exports.isFunction = internalUtil.deprecate(isFunction,
+    'util.isFunction() is deprecated. ' +
+    'Use typeof arg === \'function\' instead.');

 function isPrimitive(arg) {


I would separate out the change to isPrimitive to a separate commit or PR.

jasnell · 2016-04-30T05:38:15Z

I still say +1 on this. With exception to isRegExp(), isDate() and isPrimitive(), these are of fairly little value. The new IsPrimitive check should likely be split out to a separate commit and reconciled with the new approach v8 is taking (#6235 (comment)) but I definitely think this is the right way to go.

Fishrock123 · 2016-05-02T21:14:52Z

@jasnell Problem is that presents no consistency at all.. it's hard to justify either way.. like what will we add for future things that v8 may have checks for?

I'm less and less convinced we should even expose the v8 checks. There must be reasonable ways to get this in JS otherwise JS would present checks for it for browsers...

cc @ljharb and @bmeck ... What is the recommended way of type checking these things in JS?

On our end these are most notably used for how we render in util.inspect().

jasnell · 2016-05-02T21:30:54Z

the Proxy discussion is a good example of this. In the normal case, there's no reason for most users to need to check to see if an object is a Proxy but util.inspect() provides a valid use case for why we'd want to know if it is or not. However, I don't feel strongly about it. If you don't think there's value is having any of them, deprecate them all and don't add any new ones.

cjihrig · 2016-05-02T21:51:06Z

I'm still very much in favor of keeping the things that can't be done with 100% certainty in JavaScript without deferring to a native addon that does this same thing. Even if this is an inconsistent API, it will still be far from the worst thing in core.

cjihrig · 2016-05-02T21:52:27Z

Also, browsers don't have to account for things that cross the vm boundary.

ljharb · 2016-05-02T22:21:24Z

@Fishrock123 https://npmjs.com/~ljharb - most everything starting with "is".

If utils.is remains, I'd prefer to see them do things correctly, cross-realm.

jasnell · 2017-03-01T00:50:26Z

Ping @Fishrock123 ... just checking in on this... what do you want to do with this? I'd recommend closing if it's not yet clear if this should happen.

Fishrock123 · 2017-03-06T17:13:50Z

no clue I guess the APIs will just sit in limbo forever
¯\_(ツ)_/¯

Rename the tests appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the tests conform to the standard test structure - Rename test-regress-nodejsGH-9819 to test-crypto-tostring-segfault - Rename test-regress-nodejsGH-5051 to test-http-addrequest-localaddress - Rename test-regress-nodejsGH-5727 to test-net-listen-invalid-port - Rename test-regress-nodejsGH-5927 to test-tty-stdin-pipe - Rename test-regress-nodejsGH-6235 to test-v8-global-setter Refs: nodejs#19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the tests conform to the standard test structure. - Rename test-regress-GH-9819 to test-crypto-tostring-segfault - Rename test-regress-GH-5051 to test-http-addrequest-localaddress - Rename test-regress-GH-5727 to test-net-listen-invalid-port - Rename test-regress-GH-5927 to test-tty-stdin-pipe - Rename test-regress-GH-6235 to test-v8-global-setter PR-URL: #19275 Refs: #19105 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the tests conform to the standard test structure. - Rename test-regress-nodejsGH-9819 to test-crypto-tostring-segfault - Rename test-regress-nodejsGH-5051 to test-http-addrequest-localaddress - Rename test-regress-nodejsGH-5727 to test-net-listen-invalid-port - Rename test-regress-nodejsGH-5927 to test-tty-stdin-pipe - Rename test-regress-nodejsGH-6235 to test-v8-global-setter PR-URL: nodejs#19275 Refs: nodejs#19105 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

util: deprecate most of util.is*()

89e24dd

Fishrock123 mentioned this pull request Apr 15, 2016

Util(.is*) Deprecations #1301

Closed

mscdex reviewed Apr 15, 2016
View reviewed changes

estliberitas force-pushed the master branch 2 times, most recently from 7da4fd4 to c7066fb Compare April 26, 2016 05:23

jasnell added the wip Issues and PRs that are still a work in progress. label Apr 29, 2016

Fishrock123 mentioned this pull request Apr 29, 2016

util: fix inspecting of proxy objects #6465

Closed

3 tasks

jasnell reviewed Apr 30, 2016
View reviewed changes

jasnell mentioned this pull request Jun 7, 2016

Exposing more isXyz helpers through node_util.cc. #7196

Closed

jasnell added the stalled Issues and PRs that are stalled. label Aug 4, 2016

Trott force-pushed the master branch from b0df363 to c5ce7f4 Compare September 21, 2016 00:09

rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88 Compare October 18, 2016 17:01

MylesBorins force-pushed the master branch from 8df7ee0 to 54fef67 Compare February 1, 2017 01:00

Fishrock123 closed this Mar 6, 2017

This was referenced Mar 6, 2018

test: rename regression tests with descriptive file names #19161

Closed

test: rename regression tests with descriptive file names (pt. 3) #19275

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

util: deprecate most of util.is*() #6235

util: deprecate most of util.is*() #6235

Fishrock123 commented Apr 15, 2016 •

edited

Loading

mscdex Apr 15, 2016

trevnorris Apr 18, 2016

jasnell commented Apr 15, 2016

Fishrock123 commented Apr 19, 2016

mscdex commented Apr 19, 2016

Fishrock123 commented Apr 20, 2016

jasnell Apr 30, 2016

jasnell commented Apr 30, 2016

Fishrock123 commented May 2, 2016

jasnell commented May 2, 2016 •

edited

Loading

cjihrig commented May 2, 2016

cjihrig commented May 2, 2016

ljharb commented May 2, 2016 •

edited by tniessen

Loading

jasnell commented Mar 1, 2017

Fishrock123 commented Mar 6, 2017

util: deprecate most of util.is*() #6235

util: deprecate most of util.is*() #6235

Conversation

Fishrock123 commented Apr 15, 2016 • edited Loading

Checklist

Affected core subsystem(s)

Description of change

mscdex Apr 15, 2016

Choose a reason for hiding this comment

trevnorris Apr 18, 2016

Choose a reason for hiding this comment

jasnell commented Apr 15, 2016

Fishrock123 commented Apr 19, 2016

mscdex commented Apr 19, 2016

Fishrock123 commented Apr 20, 2016

jasnell Apr 30, 2016

Choose a reason for hiding this comment

jasnell commented Apr 30, 2016

Fishrock123 commented May 2, 2016

jasnell commented May 2, 2016 • edited Loading

cjihrig commented May 2, 2016

cjihrig commented May 2, 2016

ljharb commented May 2, 2016 • edited by tniessen Loading

jasnell commented Mar 1, 2017

Fishrock123 commented Mar 6, 2017

Fishrock123 commented Apr 15, 2016 •

edited

Loading

jasnell commented May 2, 2016 •

edited

Loading

ljharb commented May 2, 2016 •

edited by tniessen

Loading