Skip to content

Commit fac56db

Browse files
LiviaMedeirosUlisesGascon
authored andcommitted
test,benchmark: use tmpdir.fileURL()
PR-URL: #49138 Refs: #49040 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent e391f4b commit fac56db

File tree

4 files changed

+3
-16
lines changed

4 files changed

+3
-16
lines changed

Diff for: benchmark/esm/esm-loader-import.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,11 @@
22
// general startup, does not test lazy operations
33
'use strict';
44
const fs = require('node:fs');
5-
const path = require('node:path');
65
const common = require('../common.js');
76

87
const tmpdir = require('../../test/common/tmpdir.js');
9-
const { pathToFileURL } = require('node:url');
108

11-
const benchmarkDirectory = pathToFileURL(path.resolve(tmpdir.path, 'benchmark-import'));
9+
const benchmarkDirectory = tmpdir.fileURL('benchmark-import');
1210

1311
const configs = {
1412
n: [1e3],

Diff for: test/es-module/test-esm-dynamic-import-mutating-fs.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,9 @@ const tmpdir = require('../common/tmpdir');
44

55
const assert = require('node:assert');
66
const fs = require('node:fs/promises');
7-
const { pathToFileURL } = require('node:url');
87

98
tmpdir.refresh();
10-
const tmpDir = pathToFileURL(tmpdir.path);
11-
12-
const target = new URL(`./${Math.random()}.mjs`, tmpDir);
9+
const target = tmpdir.fileURL(`${Math.random()}.mjs`);
1310

1411
(async () => {
1512

Diff for: test/es-module/test-esm-dynamic-import-mutating-fs.mjs

+1-4
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,9 @@ import tmpdir from '../common/tmpdir.js';
44
import assert from 'node:assert';
55
import fs from 'node:fs/promises';
66
import { execPath } from 'node:process';
7-
import { pathToFileURL } from 'node:url';
87

98
tmpdir.refresh();
10-
const tmpDir = pathToFileURL(tmpdir.path);
11-
12-
const target = new URL(`./${Math.random()}.mjs`, tmpDir);
9+
const target = tmpdir.fileURL(`${Math.random()}.mjs`);
1310

1411
await assert.rejects(import(target), { code: 'ERR_MODULE_NOT_FOUND' });
1512

Diff for: test/node-api/test_policy/test_policy.js

-5
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,6 @@ const policyFilepath = tmpdir.resolve('policy');
2323
const depFilepath = require.resolve(`./build/${common.buildType}/binding.node`);
2424
const depURL = pathToFileURL(depFilepath);
2525

26-
const tmpdirURL = pathToFileURL(tmpdir.path);
27-
if (!tmpdirURL.pathname.endsWith('/')) {
28-
tmpdirURL.pathname += '/';
29-
}
30-
3126
const depBody = fs.readFileSync(depURL);
3227
function writePolicy(...resources) {
3328
const manifest = { resources: {} };

0 commit comments

Comments
 (0)