-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test,benchmark: use tmpdir.fileURL()
#49138
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
LiviaMedeiros:test-tmpdir-fileurl-leftover
Aug 21, 2023
Merged
test,benchmark: use tmpdir.fileURL()
#49138
nodejs-github-bot
merged 1 commit into
nodejs:main
from
LiviaMedeiros:test-tmpdir-fileurl-leftover
Aug 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
benchmark
Issues and PRs related to the benchmark subsystem.
esm
Issues and PRs related to the ECMAScript Modules implementation.
needs-ci
PRs that need a full CI run.
node-api
Issues and PRs related to the Node-API.
test
Issues and PRs related to the tests.
labels
Aug 13, 2023
This comment was marked as outdated.
This comment was marked as outdated.
25 tasks
lpinca
approved these changes
Aug 15, 2023
This comment was marked as outdated.
This comment was marked as outdated.
24 tasks
This comment was marked as outdated.
This comment was marked as outdated.
26 tasks
LiviaMedeiros
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Aug 17, 2023
This was referenced Aug 18, 2023
LiviaMedeiros
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 21, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 21, 2023
Landed in eeddbfa |
Merged
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49138 Refs: nodejs/node#49040 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49138 Refs: nodejs/node#49040 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
benchmark
Issues and PRs related to the benchmark subsystem.
esm
Issues and PRs related to the ECMAScript Modules implementation.
needs-ci
PRs that need a full CI run.
node-api
Issues and PRs related to the Node-API.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #49040