-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug call illustration in the cluster doc does not match with output in Windows #10255
Comments
The use of NODE_DEBUG should be removed and the workers should print the log message directly from the example code right before or after createServer() The debug statements are gone now since the 0.12 cluster rewrite. Feel free to PR an improvement. |
sam-github
added
cluster
Issues and PRs related to the cluster subsystem.
doc
Issues and PRs related to the documentations.
labels
Dec 13, 2016
2 tasks
@sam-github Done. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the preface of the cluster doc the first code example is followed by a shell illustration of a debug script call:
However, I can't get the same output in Windows:
I've tried to find in the
cluster.js
any checks forNODE_DEBUG
or anyutil.debuglog()
calls and I could not find any.Is this illustration still valid?
Is it not valid only for Windows?
Is this note after the illustration supposed to explain the output difference in Windows:
Should the document fragment be somehow clarified more?
The text was updated successfully, but these errors were encountered: