Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making URL prototype properties enumerable to match the spec #10376

Closed
domenic opened this issue Dec 21, 2016 · 3 comments
Closed

Consider making URL prototype properties enumerable to match the spec #10376

domenic opened this issue Dec 21, 2016 · 3 comments
Labels
url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@domenic
Copy link
Contributor

domenic commented Dec 21, 2016

In the URL Standard, they are defined by Web IDL, which defines them to be enumerable. (Except constructor which is enumerable: false).
@addaleax addaleax added the url Issues and PRs related to the legacy built-in url module. label Dec 21, 2016
@jasnell
Copy link
Member

jasnell commented Dec 21, 2016

+1... this has been on my todo list.

@joyeecheung
Copy link
Member

@jasnell Mind if I make a PR for this?

@jasnell
Copy link
Member

jasnell commented Dec 21, 2016 via email

@joyeecheung joyeecheung mentioned this issue Dec 22, 2016
Closed
3 tasks
joyeecheung added a commit to joyeecheung/node that referenced this issue Dec 29, 2016
@joyeecheung
url: make WHATWG URL properties spec compliant
126d6e7 
* Set exposed attributes of the interface enumerable
  and configurable, as required by the spec.
  See: https://heycam.github.io/webidl/#es-attributes
* Make sure `URL#searchParams` returns `[[SameObject]]`
* Add the missing `URL#href` setter
* Reorder the properties to match
  https://url.spec.whatwg.org/#api
* Add tests for the ECMAScript property attributes

Fixes: nodejs#10376
jasnell pushed a commit that referenced this issue Dec 30, 2016
@joyeecheung @jasnell
url: make WHATWG URL properties spec compliant
508d976 
* Set exposed attributes of the interface enumerable
  and configurable, as required by the spec.
  See: https://heycam.github.io/webidl/#es-attributes
* Make sure `URL#searchParams` returns `[[SameObject]]`
* Add the missing `URL#href` setter
* Reorder the properties to match
  https://url.spec.whatwg.org/#api
* Add tests for the ECMAScript property attributes

PR-URL: #10408
Fixes: #10376
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this issue Jan 3, 2017
@joyeecheung @evanlucas
benchmark: add benchmark for WHATWG URL properties
fe813ec 
PR-URL: #10408
Fixes: #10376
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this issue Jan 3, 2017
@joyeecheung @evanlucas
url: make WHATWG URL properties spec compliant
eb4f8b7 
* Set exposed attributes of the interface enumerable
  and configurable, as required by the spec.
  See: https://heycam.github.io/webidl/#es-attributes
* Make sure `URL#searchParams` returns `[[SameObject]]`
* Add the missing `URL#href` setter
* Reorder the properties to match
  https://url.spec.whatwg.org/#api
* Add tests for the ECMAScript property attributes

PR-URL: #10408
Fixes: #10376
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this issue Jan 4, 2017
@joyeecheung @evanlucas
benchmark: add benchmark for WHATWG URL properties
0b2bc5e 
PR-URL: #10408
Fixes: #10376
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this issue Jan 4, 2017
@joyeecheung @evanlucas
url: make WHATWG URL properties spec compliant
7fbd12f 
* Set exposed attributes of the interface enumerable
  and configurable, as required by the spec.
  See: https://heycam.github.io/webidl/#es-attributes
* Make sure `URL#searchParams` returns `[[SameObject]]`
* Add the missing `URL#href` setter
* Reorder the properties to match
  https://url.spec.whatwg.org/#api
* Add tests for the ECMAScript property attributes

PR-URL: #10408
Fixes: #10376
Reviewed-By: James M Snell <jasnell@gmail.com>
@joyeecheung joyeecheung added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

url: make WHATWG URL properties spec compliant joyeecheung/node
4 participants
@jasnell @domenic @addaleax @joyeecheung