-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
url: add sort() to URLSearchParams #10760
Comments
PR: whatwg/url#199 Note: the current proposal requires a stable sorting algorithm. |
whatwg/url#199 has been merged. Is there an existing stable sort function in the code base? If not, I'll just make a simple insertion sort (or copy the one in V8), which is stable. |
If we use an array of tuples as the underlying data structure instead of flattening them out, we can just use |
Also I remember there was discussion about moving the parsing bit to C++, for reference, blink does it with a |
@joyeecheung, we can't use |
Fixes: nodejs#10760 Ref: whatwg/url#26 Ref: whatwg/url#199 Ref: web-platform-tests/wpt#4531
PR-URL: #11098 Fixes: #10760 Ref: whatwg/url#26 Ref: whatwg/url#199 Ref: web-platform-tests/wpt#4531 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Backport-of: nodejs#11098 Fixes: nodejs#10760 Ref: whatwg/url#26 Ref: whatwg/url#199 Ref: web-platform-tests/wpt#4531
Backport-of: nodejs#11098 Fixes: nodejs#10760 Ref: whatwg/url#26 Ref: whatwg/url#199 Ref: web-platform-tests/wpt#4531
Backport-of: #11098 Fixes: #10760 Ref: whatwg/url#26 Ref: whatwg/url#199 Ref: web-platform-tests/wpt#4531
whatwg/url#26 proposes adding a
sort()
capability toURLSearchParams
. The idea would be to have a simple default lexical sort of keys. If added, we would need to add this to the APIThe text was updated successfully, but these errors were encountered: