Linter rule: use ASCII quotes not Unicode ones

[gibfahn]

• Subsystem: eslint

See: #11129 (comment)

I added a second commit that replaces a few U+2019 quotes with ASCII quotes so that their files can be stored as one-byte strings.
Probably one for another PR, but this sounds like a good candidate for a lint rule.

Basically we need a lint rule that checks for U+2019 quotes: ’, and suggests that they be replaced with ASCII quotes: '.

cc/ @bnoordhuis @richardlau

[addaleax]

Two things:

• This should apply to lib/ and only to lib/, because that’s where we need it.
• This isn’t really about quotation marks; ideally, any non-ASCII character would be forbidden (sigh)…

[silverwind]

We could do something like this (match is fed to the RegExp constructor):

- match: '’'
  replacement: '\''
- match: '[—–]'
  replacement: '-' 
- match: '[^\x00-\x7F]'
  replacement: ''

The last one might be a bit extreme :)

[aqrln]

@silverwind I'd also add replacements for “” and «» to ASCII double quotes.

[silverwind]

You can always contribute improvements later, above is just about the general rule config layout.

[gibfahn]

I'd also add replacements for “” and «» to ASCII double quotes.

This is an open issue looking for someone to raise a PR. If whoever raises it wants to include those then that sounds good to me.

[not-an-aardvark]

If the goal is to allow files to be stored as one-byte strings, would it be better for the rule to just disallow all non-ascii characters in files?

edit: Never mind, I see @addaleax also mentioned this above.

[hkal]

@gibfahn I'll give this a go if no one else is assigned.

[gibfahn]

@hkal go for it!

[hkal]

Do we still need this after #11129?

cc @bnoordhuis

[bnoordhuis]

Would be good to enforce it because Unicode files take up twice as much space in the binary as plain ASCII files.