tls documentation says that checkServerIdentity function should throw an error. It should not. #11467
Comments
mscdex
added
tls
|
fixed in #10846, but no one spoke up for it I'll try to factor pieces of those docs out and get them accepted |
4 tasks
sam-github
added a commit
to sam-github/node
that referenced
this issue
Feb 20, 2017
Direct use of tls.TLSSocket to start a TLS session over an existing TCP connection was documented. However, to use this connection securely it is necessary to validate and authenticate the peer's certificate, and the documented events and properties are implemented only for TLSSockets returned by tls.connect(). In order to create secure connections, additional undocumented APIs must be used, and these APIs are being called right now by npm modules. Fix: nodejs#10555 Fix: nodejs#11467
|
@sam-github Should this remain open? |
|
yes, the docs are wrong |
2 tasks
|
Fixed by #17203 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The documentation for the
checkServerIdentityfunction at https://nodejs.org/api/tls.html#tls_tls_connect_options_callbackstates that the provided function "should throw an error if verification fails. "
However, the implementation (https://github.com/nodejs/node/blob/master/lib/_tls_wrap.js#L1083) expects a truthy value returned from the function as the error, and has no try / catch logic to catch an error if thrown, with the result that if the
checkServerIdentityfunction throws an error the whole process will likely exit. Either the docs or the implementation should be corrected to reflect the intended behavior.The text was updated successfully, but these errors were encountered: