Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: track whatwg url issue #259 #11785

Closed
watilde opened this issue Mar 10, 2017 · 0 comments
Closed

url: track whatwg url issue #259 #11785

watilde opened this issue Mar 10, 2017 · 0 comments
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@watilde
Copy link
Member

watilde commented Mar 10, 2017

Refs: whatwg/url#259

This issue is proposing a change to the way the file protocol is handled. As file URLs cannot have username/password/port the state machine will not allow changing the scheme of an URL to file if it contains credentials or a non-null port.
@watilde watilde added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Mar 10, 2017
@watilde watilde mentioned this issue Mar 17, 2017
Closed
3 tasks
watilde added a commit to watilde/node that referenced this issue Mar 18, 2017
@watilde
url: restrict setting protocol to "file"
9d4d73f 
Since file URLs can not have `username/password/port`,
the specification was updated to restrict setting protocol to "file".

Refs: whatwg/url#269
Fixes: nodejs#11785
jungx098 pushed a commit to jungx098/node that referenced this issue Mar 21, 2017
@watilde @jungx098
url: restrict setting protocol to "file"
361e65f 
Since file URLs can not have `username/password/port`,
the specification was updated to restrict setting protocol to "file".

Refs: whatwg/url#269
Fixes: nodejs#11785
PR-URL: nodejs#11887
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins pushed a commit that referenced this issue Mar 28, 2017
@watilde @MylesBorins
url: restrict setting protocol to "file"
c51d925 
Since file URLs can not have `username/password/port`,
the specification was updated to restrict setting protocol to "file".

Refs: whatwg/url#269
Fixes: #11785
PR-URL: #11887
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@watilde