Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate flaky test-domain-abort-on-uncaught #11814

Closed
Trott opened this issue Mar 12, 2017 · 3 comments
Closed

investigate flaky test-domain-abort-on-uncaught #11814

Trott opened this issue Mar 12, 2017 · 3 comments
Assignees
Labels
arm Issues and PRs related to the ARM platform. domain Issues and PRs related to the domain subsystem. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Mar 12, 2017

  • Version: v8.0.0-pre
  • Platform: armv7-ubuntu1404
  • Subsystem: domain

https://ci.nodejs.org/job/node-test-commit-arm/8238/nodes=armv7-ubuntu1404/console

not ok 295 parallel/test-domain-abort-on-uncaught
  ---
  duration_ms: 1.834
  severity: fail
  stack: |-
    
    assert.js:81
      throw new assert.AssertionError({
      ^
    AssertionError: Test at index 7 should have exited with exit code 0 but instead exited with code 134 and signal null
        at ChildProcess.onExit (/home/iojs/build/workspace/node-test-commit-arm/nodes/armv7-ubuntu1404/test/parallel/test-domain-abort-on-uncaught.js:251:14)
        at emitTwo (events.js:127:13)
        at ChildProcess.emit (events.js:215:7)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:208:12)
@Trott Trott added arm Issues and PRs related to the ARM platform. domain Issues and PRs related to the domain subsystem. test Issues and PRs related to the tests. labels Mar 12, 2017
@Trott
Copy link
Member Author

Trott commented Mar 12, 2017

This test is flaky under load. This can be seen by running it with a command like this:

tools/test.py -j 32 --repeat=32 test/parallel/test-domain-abort-on-uncaught.js

(If 32 isn't enough to cause problems on your setup, try 64 or higher.)

There are at least three solutions possible here:

  • move the test to sequential
  • break the test up into as many as 13 separate test files so that each one is launching one additional node process rather than one test launching 13 of them in parallel
  • rewrite the test to run the 13 processes sequentially rather than in parallel

I'll open a PR to move to sequential. The second or third option above can be a good first contribution for someone.

@Trott Trott self-assigned this Mar 12, 2017
Trott added a commit to Trott/io.js that referenced this issue Mar 12, 2017
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

Fixes: nodejs#11814
@Trott
Copy link
Member Author

Trott commented Mar 12, 2017

Fix in #11817

@gibfahn
Copy link
Member

gibfahn commented Mar 13, 2017

  • break the test up into as many as 13 separate test files so that each one is launching one additional node process rather than one test launching 13 of them in parallel
  • rewrite the test to run the 13 processes sequentially rather than in parallel

I'll open a PR to move to sequential. The second or third option above can be a good first contribution for someone.

I'll open a new issue for this (as I assume this one will be closed by #11817).

EDIT: Issue raised: #11826

italoacasas pushed a commit to italoacasas/node that referenced this issue Mar 20, 2017
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: nodejs#11817
Fixes: nodejs#11814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jungx098 pushed a commit to jungx098/node that referenced this issue Mar 21, 2017
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: nodejs#11817
Fixes: nodejs#11814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Apr 18, 2017
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: #11817
Fixes: #11814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Apr 19, 2017
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: #11817
Fixes: #11814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
andrew749 pushed a commit to michielbaird/node that referenced this issue Jul 19, 2017
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: nodejs/node#11817
Fixes: nodejs/node#11814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Issues and PRs related to the ARM platform. domain Issues and PRs related to the domain subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants