-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: typo in api/process.md #12565
Comments
I can make this change. |
I have this ready but it's blocked by another PR :-(. Once that one clears I can send this one. |
@morrme what do you mean by blocked? You can have lots of PRs open at the same time. I see that your git fetch --all # Make sure you have the latest changes
git checkout issue12565
git push # Make sure your remote branches are up to date
git reset --hard upstream/master # Assumes nodejs/node remote is called upstream
git cherry-pick origin/issue12565 # Assumes morrme/node remote is called origin
git push --force-with-lease The Then you can raise another Pull Request with: master...morrme:issue12565 |
@gibfahn that's what' I meant. I am so embarrassed to have made such a mistake! I found a similar fix but we've gotten so far with the CI jobs issue, I was worried about messing it up. I will give it a try. Thanks for your support, as always! |
Git is hard, no need to be embarassed 😁 . After the
That's a very reasonable thing to worry about. The trick is to run |
THANK YOU @gibfahn ! 🏆 |
PR-URL: nodejs/node#12612 Fixes: nodejs/node#12565 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: David Cai <davidcai1993@yahoo.com>
In doc/api/process.md, there is a typo in the 'A note on process I/O' section where it says:
where
console.write()
should presumably instead beconsole.error()
, sinceconsole.write()
does not exist andconsole.error()
is the only otherconsole
method referred to in that section.The text was updated successfully, but these errors were encountered: