Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note that whatwg-url tests should not be modified #12793

Closed
gibfahn opened this issue May 2, 2017 · 3 comments
Closed

Note that whatwg-url tests should not be modified #12793

gibfahn opened this issue May 2, 2017 · 3 comments
Labels
good first issue Issues that are suitable for first-time contributors. test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation. wip Issues and PRs that are still a work in progress.

Comments

@gibfahn
Copy link
Member

gibfahn commented May 2, 2017 •
edited
Loading

  • Version: master
  • Subsystem: test, url

Add a comment to the whatwg-url tests to document that we should not modify them since they are imported tests.

Refs: #12669 (comment) and #12743 (comment)

cc/ @Trott @joyeecheung @cjihrig
@gibfahn gibfahn added good first issue Issues that are suitable for first-time contributors. mentor-available test Issues and PRs related to the tests. labels May 2, 2017
@joyeecheung
Copy link
Member

Tips: the whatwg-url tests are test/parallel/test-whatwg-*.js, the meaning of the wrapper can be found in https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#imported-tests

@mscdex mscdex added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label May 2, 2017
@refack refack mentioned this issue May 2, 2017
Closed
24 tasks
@refack
Copy link
Contributor

refack commented May 2, 2017

@gibfahn added "Since they are Imported Tests" to first comment if that's Ok.

@Trott
Copy link
Member

Trott commented May 2, 2017

Additional information:

  • It's not the entire test file that shouldn't be modified, but most of the test file. Most of each test is copied from the canonical WPT tests and that part should not be modified. While we might accept a blanket "do not modify this test" comment, it would be preferable if the comment were clear about what part of the test should not be modified.

@rayto510 rayto510 mentioned this issue May 2, 2017
Closed
4 tasks
@gautamarora gautamarora mentioned this issue Jul 18, 2017
Closed
3 tasks
@refack refack added the wip Issues and PRs that are still a work in progress. label Jul 19, 2017
@refack refack closed this as completed in 9e4ab6c Jul 20, 2017
addaleax pushed a commit that referenced this issue Jul 22, 2017
@gautamarora @addaleax
test: add comments for whatwg-url tests
a34ac21 
Added comments to whatwg-url tests that they should not be changed until
modifications are merged upstream as per "Web Platform Tests" guidelines

PR-URL: #14355
Fixes: #12793
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this issue Jul 24, 2017
@gautamarora @Fishrock123
test: add comments for whatwg-url tests
0197ba0 
Added comments to whatwg-url tests that they should not be changed until
modifications are merged upstream as per "Web Platform Tests" guidelines

PR-URL: #14355
Fixes: #12793
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are suitable for first-time contributors. test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation. wip Issues and PRs that are still a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add comment to all whatwg-url tests
5 participants
@mscdex @refack @Trott @joyeecheung @gibfahn