Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: http.request and https.request accepts WHATWG URL object as argument #13383

Closed
joyeecheung opened this issue Jun 2, 2017 · 0 comments
Closed

doc: http.request and https.request accepts WHATWG URL object as argument #13383

joyeecheung opened this issue Jun 2, 2017 · 0 comments
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.

Comments

@joyeecheung
Copy link
Member

  • Version: master
  • Subsystem: doc

After #10638 http.request and https.request (hence http.get and https.get) takes an WHATWG URL object as argument. This has not been documented yet and can be a good first contribution. Changing the type annotations in doc/api/http.md and doc/api/https.md and the description of those arguments should be enough.
@joyeecheung joyeecheung added doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. labels Jun 2, 2017
@vladimir-trifonov vladimir-trifonov mentioned this issue Jun 2, 2017
Closed
3 tasks
vladimir-trifonov added a commit to vladimir-trifonov/node that referenced this issue Jun 4, 2017
@vladimir-trifonov
doc: Add URL argument with http/https request
b3e3ff0 
Fixes: nodejs#13383
jasnell pushed a commit that referenced this issue Jun 7, 2017
@vladimir-trifonov @jasnell
doc: Add URL argument with http/https request
a117bcc 
PR-URL: #13405
Fixes: #13383
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: Add URL instance as options argument with http.request and https… vladimir-trifonov/node
1 participant
@joyeecheung